Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
...
This comparison is big! We’re only showing the most recent 250 commits
Commits on Mar 18, 2015
@cupakromer cupakromer Merge pull request #1289 from tinynumbers/view-example-helper-class-bug
If a view example's description contains no path elements, then do not attempt to load a helper based on the example description.
03afd47
@cupakromer cupakromer Update CHANGELOG [ci skip] f5af60f
@cupakromer cupakromer Fix action mailer preview path setup.
This removes the unnecessary warning about a preview path set to a
location other than `/spec/mailers/preview`.

This does not force `ActionMailer` to load when the Railtie runs by
removing the `defined?` check. This is necessary because the
`ActionMailer` class only loads it's settings once, after it is first
loaded. If we load the class in our Railtie any custom settings declared
in a config block in an initializer will be ignored.

An improved spec suite for the different permutations of availability of
action mailer previews is included as well.
172813d
@cupakromer cupakromer Add fix to changelog [ci skip] f61100e
@cupakromer cupakromer Merge pull request #1327 from rspec/update-action-mailer-railtie
Fix action mailer preview path setup.
fba0669
Commits on Apr 09, 2015
@orien orien Check `need_auto_run=` method is defined also 6092959
Commits on Apr 12, 2015
@orien orien extract `disable_testunit_autorun` method ffed381
Commits on Apr 15, 2015
@jgorset jgorset Provide a summary for humans d49058e
@JonRowe JonRowe Merge pull request #1354 from jgorset/patch-1
Provide a summary for humans
f1295b7
Commits on Apr 16, 2015
@cupakromer cupakromer Merge pull request #1350 from orien/test_unit_method
Check `need_auto_run=` method is defined also
32f0618
@cupakromer cupakromer Update changelog with issue #1350 [ci skip] a09a623
Commits on May 05, 2015
@JonRowe JonRowe Updated travis build scripts (from rspec-dev)
5c96e08
@gabetax gabetax Add JobExampleGroup to support :type => :job b40cda6
Commits on May 06, 2015
@JonRowe JonRowe Merge pull request #1360 from rspec/update-travis-build-scripts-2015-…
…05-05-for-master

Updates from rspec-dev (2015-05-05)
5d323ed
@gabetax gabetax only mix RailsExampleGroup into JobExampleGroup if ActiveJob is defined af53b75
@gabetax gabetax only initialize JobExampleGroup if ActiveJob is defined 79ff968
Commits on May 07, 2015
@JonRowe JonRowe Merge pull request #1361 from gabetax/infer_spec_type_for_jobs
Add JobExampleGroup to support :type => :job
316ddeb
@JonRowe JonRowe changelog and cleanup for #1361
[skip ci]
0ba1ad2
Commits on May 08, 2015
@jfvanderwalt jfvanderwalt fix: spelling of convenience in README.
5ab11b1
@cupakromer cupakromer Merge pull request #1364 from jfvanderwalt/jv-fix-spelling-error-in-r…
…eadme

fix: spelling of convenience in README.

[ci skip]
2beffdc
Commits on May 23, 2015
@cupakromer cupakromer Fix load order :bug:
This fixes an "undefined method `fixture_path`" error caused in
`RSpec::Core::Configuration`. The issue occurs when a spec is created
before rspec-rails is loaded. The cause is rspec-core attempts to
include the `RSpec::Rails::FixtureSupport` module into the existing spec
as soon as we tell the configuration about it, but have not told the
configuration about the new related options.

This moves the including of the module until after we have told the
configuration about the dependent options.

This includes a spec which is named in a manner to attempt to ensure it
is the first spec loaded by rspec-core; which loads spec files
alphabetically. To ensure we test the issue the run script is updated to
also run this spec file standalone.

When discussing rspec/rspec-rails#1355 it was agreed that we need to
consider removing this global inclusion of the fixture support. Instead
favoring including it in the `RailsExampleGroup`. A deprecation comment
has been included to remind us later.
11ba7f7
@cupakromer cupakromer Update spec to remove hooks.
This changes to nearly mirrors how the configuration is tested in rspec-core.
Instead of setting up a new configuration object each test run, we clone
the existing object. This does two things:

- prevents polluting the actual test configuration
- instead of creating a new configuration it clones the existing one to
  ensure we actually modify the RSpec config
b78356f
@cupakromer cupakromer Add specs around existing settings
These specs are in a more integration style; instead of a more
unit-collaborator approach which would simply ensure that the proper
messages were sent to the configuration object.

The reason is that users of rspec-rails have specific expectations on
how the configuration options are available. If rspec-core changes
anything related to these calls that will break the rspec-rails user's
expectations. To ensure that doesn't happen we are fully testing the
integration between our shim and the `RSpec.configuration`.
b81f6de
@cupakromer cupakromer Prep for removal of fixture support globally.
This adds metadata to ad-hoc include fixture support for any examples or
groups which may require it. It additionally, includes fixture support
into all default `RailsExampleGroup` modules. This provides the current
functionality for the majority of use cases.
fd00f38
@cupakromer cupakromer Use default `.rspec` configuration. 98c161f
@cupakromer cupakromer Note updates in changelog.
[ci skip]
278972d
Commits on May 24, 2015
@josephgrossberg josephgrossberg consistent quoting, more readable interpolation 8197094
@JonRowe JonRowe Merge pull request #1375 from josephgrossberg/patch-1
consistent quoting, more readable interpolation
192da8a
Commits on May 25, 2015
@cupakromer cupakromer Merge pull request #1372 from rspec/update-fixture-support
Update fixture support
479d2d0
@cupakromer cupakromer Include `rspec:request` generator.
This includes a generator for "request" specs. There already exists a
generator which creates these specs, but it is called "integration".
The existing name comes from the legacy implementations attempting to
mirror the Rails test style names for the RSpec equivalent specs.

Since these two generators are identical, except for the name, this
makes the new `RequestGenerator` a subclass of the existing
`IntegrationGenerator`. Alternatively, we could have decided to make
`RequestGenerator` the parent class, moving the existing functionality
into it. While this is arguably the "proper" way of thinking about the
generators, it could potentially break some existing applications; even
though these classes are marked `private`. There's no harm for now in
keeping semver compliant by making this generator additive.

Since the two generators are exactly the same this uses a shared example
to keep the specs in-sync.

Resolve #1377
66bb6a7
@cupakromer cupakromer Update existing generator specs.
This updates the existing generator specs:

- Remove old `require 'spec_helper'`; `.rspec` does this now
- Do not use the monkey patch version of `describe`
- Use the generator support macros for the shared common setup
5b10339
@cupakromer cupakromer Update changelog with `rspec:request` generator.
[ci skip]
33f42fc
@cupakromer cupakromer Make yard available in the test environment
This fixes the error generated by the script when attempting to check
documentation coverage:

> /.gem/ruby/2.2.2/gems/bundler-1.9.4/lib/bundler/rubygems_integration.rb:316:in `block in replace_bin_path': can't find executable yard (Gem::Exception)
>         from bin/yard:16:in `<main>'
2c31ce1
@cupakromer cupakromer Achieve 100% doc coverage
Both of these are meant to be private APIs. They were not marked as such
before because the `bin/yard` command was failing previously.
2345fcb
@cupakromer cupakromer Address yard warnings
> [warn]: in YARD::Handlers::Ruby::MethodHandler: Undocumentable method defined on object instance
> [warn]:         in file 'lib/rspec/rails/configuration.rb':73:
>
>         73: def config.render_views=(val)
>
> [warn]: in YARD::Handlers::Ruby::MethodHandler: Undocumentable method defined on object instance
> [warn]:         in file 'lib/rspec/rails/configuration.rb':77:
>
>         77: def config.render_views
>
> [warn]: in YARD::Handlers::Ruby::MethodHandler: Undocumentable method defined on object instance
> [warn]:         in file 'lib/rspec/rails/configuration.rb':81:
>
>         81: def config.render_views?
>
> [warn]: in YARD::Handlers::Ruby::MethodHandler: Undocumentable method defined on object instance
> [warn]:         in file 'lib/rspec/rails/configuration.rb':85:
>
>         85: def config.infer_spec_type_from_file_location!
>
> [warn]: Syntax error in `lib/generators/rspec/mailer/templates/preview.rb`:(1,1): syntax error, unexpected '<'
> [warn]: in YARD::Handlers::Ruby::MixinHandler: Undocumentable mixin: YARD::Parser::UndocumentableError for class RSpec::Rails::RoutingExampleGroup
> [warn]:         in file 'lib/rspec/rails/example/routing_example_group.rb':11:
>
>         11: include RSpec::Rails::AssertionDelegator.new(ActionDispatch::Assertions::RoutingAssertions)
>
> [warn]: in YARD::Handlers::Ruby::MixinHandler: Undocumentable mixin: YARD::Parser::UndocumentableError for class RSpec::Rails::ControllerExampleGroup
> [warn]:         in file 'lib/rspec/rails/example/controller_example_group.rb':12:
>
>         12: include RSpec::Rails::AssertionDelegator.new(ActionDispatch::Assertions::RoutingAssertions)
>
> [warn]: Syntax error in `lib/generators/rspec/install/templates/spec/rails_helper.rb`:(23,1): syntax error, unexpected '<', expecting end-of-input
a640902
@cupakromer cupakromer Reach minimal 100% doc coverage.
This addresses doc coverage issues with the most recent release of YARD.
cd67b84
@JonRowe JonRowe Merge pull request #1378 from rspec/add-request-generator
Add request generator
e692909
Commits on May 26, 2015
@cupakromer cupakromer Fix `controller` attribute access.
This fixes the access to the controller attribute, making it clear that
the setter should be a `private` internal API. This was reflected
previously in the YARD doc, but that did not match the code.
03d8cbe
@cupakromer cupakromer Merge pull request #1379 from rspec/address-yard-issues
Address yard issues
57d26eb
Commits on May 27, 2015
@cupakromer cupakromer Prevent running in production mode by default.
Many setups start tests by truncating the database tables. Running the
specs in production would, horribly, would delete all of the data. This
checks to make sure Rails is not in production before loading
rspec-rails and the configuration. If production mode is detected the
run will abort immediately.

Resolve #1382
b913f6a
@cupakromer cupakromer Update changelog with new `rails_helper` check.
[ci skip]
5d27de7
@cupakromer cupakromer Merge pull request #1383 from rspec/include-production-check
Prevent running in production mode by default.
a2a37ee
Commits on May 28, 2015
@takiy33 takiy33 Removed deprecated option from .gemspec
0017b92
@cupakromer cupakromer Merge pull request #1384 from takiy33/takiy33-patch-1
Removed deprecated option from .gemspec

[ci skip]
18ec8f5
Commits on Jun 03, 2015
@myronmarston myronmarston Forwardport 3.2.2 release notes.
[ci skip]
7bb6ea4
Commits on Jun 04, 2015
@cupakromer cupakromer Expose broken `ActionMailer` preview setup.
This fixes the spec suite to expose issues with `ActionMailer` being
configured incorrectly when previews are not available.

This addresses several issues:

- The incorrect configuration options are only exposed once
  `ActionMailer::Base` is loaded; this forces the class to load in the
  mailer initializer and at the end of our script
- This adds specs specifically for the "development" environment which
  were missing before; it appeared that by not setting the environment
  it would default to "development" per the script, however, when the
  command shells out the `RAILS_ENV` is already set to "test" from rspec
  running.

  To be certain we cover the other possible edge cases we specifically
  add more tests for `ActionMailer` not being available, and for a
  custom configuration being set after `rspec-rails` is loaded.
- Despite us asking Rails to turn off eager loading in our custom
  script, several files were still getting eager loaded; this
  explicitly clears the eager load paths to stop this
- This fixes how the mailer script is shelled out in Ruby 1.8.7; now the
  environment variables are properly formatted and standard error is
  piped to standard out

Exposes the regression issue in #1386
9522842
@cupakromer cupakromer Fix regression issue with `preview_path=`
The `preview_path` feature of `ActionMailer` was added in Rails 4.1.
Versions before that release are not able to handle that configuration.
The regression issue occurred in part to the spec suite overlooking
changes to the environment and how that affects the shelling out.

Additionally, the previous changes noted that the configuration for a
particular module always responds to a setting; even when it should not.
However, while this logic was noted for `show_previews`, a few lines
further down, that same logic was overlooked for `preview_path`.

It appears the only available methods for detecting `ActionMailer`, and
it's features, is tasting the top-level `config` in addition to checking
the Rails version string.
729b1db
@cupakromer cupakromer Update changelog with `preview_path=` fix
[ci skip]
adaf823
Commits on Jun 05, 2015
@cupakromer cupakromer Improve comment
Provide a more accurate description of the behavior we are avoiding and
why the current behavior is used.

[ci skip]
09c0ce1
@JonRowe JonRowe Merge pull request #1388 from rspec/fix-regression-mailer-preview-path
Fix regression mailer preview path
e9fb455
Commits on Jun 08, 2015
@myronmarston myronmarston Forwardport 3.2.3 release notes.
[ci skip]
2fb5619
Commits on Jun 12, 2015
@myronmarston myronmarston Updates changelog for v3.3.0 [ci skip] 3419999
@myronmarston myronmarston Release 3.3.0 bd11b95
@myronmarston myronmarston Bump version to 3.4.0.pre. cdc7711
Commits on Jun 13, 2015
@myronmarston myronmarston Fix regression with stubbing ActiveRecord model classes.
Fixes #1394.
See also rspec/rspec-mocks#972.
4e8c36c
@cupakromer cupakromer Include acceptance specs for smoke app
Add an acceptance spec to the smoke app verifying that neither
rspec-rails nor rspec-mocks has broken working models. This ensures the
following basic functionality:

- stubbing model class methods
- attribute methods (currently the only dynamic AR type method we support)
811e1cb
@myronmarston myronmarston Merge pull request #1395 from rspec/fix-ar-stubbing
Fix regression with stubbing ActiveRecord model classes.
d0447fa
Commits on Jun 14, 2015
@myronmarston myronmarston Forwardport 3.3.1 release notes.
[ci skip]
5ee901f
Commits on Jun 16, 2015
@JonRowe JonRowe ignore rspec persistance file e298fa5
@JonRowe JonRowe prevent define_attribute_methods from running on abstract classes
2ebc177
@JonRowe JonRowe Merge pull request #1396 from rspec/fix_abstract_class_allow
Fix verified partial doubles with abstract classes.
f270e29
Commits on Jun 18, 2015
@JonRowe JonRowe refactor rspec-mocks callback to only run on active record subclasses…
… without respond_to checks
d46e4f3
@JonRowe JonRowe Merge pull request #1398 from rspec/alternate_callback
Refactor verifying doubles callback
503a404
@myronmarston myronmarston Forwardport 3.3.2 release notes.
[ci skip]
1fb6f9f
Commits on Jul 03, 2015
@dankohn dankohn Namespace check shouldn't fail on symbols; fixes #1412
Fixes #1412 by converting symbols to strings in check.
40350d8
Commits on Jul 06, 2015
@JonRowe JonRowe Merge pull request #1414 from spreemo/dankohn-symbol-namespace-1412
Namespace check shouldn't fail on symbols; fixes #1412
be695b0
@JonRowe JonRowe changelog for #1414
[skip ci]
d856f64
Commits on Jul 10, 2015
@myronmarston myronmarston Ignore specs.out since our build scripts produce that as an artifact.…
… [ci skip]
eeab7d2
@myronmarston myronmarston Updated common markdown files (from rspec-dev) [ci skip] f2dd11b
@myronmarston myronmarston Merge pull request #1418 from rspec/update-common-markdown-files-2015…
…-07-09-for-master

Updates from rspec-dev (2015-07-09)
98b4a2d
@myronmarston myronmarston Updated travis build scripts (from rspec-dev)
b917f1d
Commits on Jul 15, 2015
@myronmarston myronmarston Forwardport 3.3.3 release notes.
[ci skip]
1e55b0f
Commits on Jul 25, 2015
@myronmarston myronmarston Updated common markdown files (from rspec-dev) [ci skip] 8e0226c
Commits on Jul 27, 2015
@cupakromer cupakromer Merge pull request #1419 from rspec/update-travis-build-scripts-2015-…
…07-10-for-master

Updates from rspec-dev (2015-07-10)
2ab21c3
@cupakromer cupakromer Merge pull request #1422 from rspec/update-common-markdown-files-2015…
…-07-24-for-master

Updates from rspec-dev (2015-07-24)
a189fcf
@cupakromer cupakromer Update travis to specify specific branches to run.
This moves the Travis CI config inline with the rest of the RSpec repos.
This will also help reduce the load on the Travis system for rspec-rails
PRs when the PR branch is a branch in the repo itself.
781cba1
@cupakromer cupakromer Merge pull request #1423 from rspec/update-travis
Update travis to specify specific branches to run.
926e670
Commits on Jul 28, 2015
@myronmarston myronmarston Updated common markdown files (from rspec-dev) [ci skip] 69671f8
@myronmarston myronmarston Merge pull request #1425 from rspec/update-common-markdown-files-2015…
…-07-27-for-master

Updates from rspec-dev (2015-07-27)
b756783
Commits on Jul 31, 2015
@jamelablack jamelablack Update README.md
[ci skip]
f2229f1
@jamelablack jamelablack Rename code_of_conduct.md to CODE_OF_CONDUCT.md
[ci skip]
93d1a85
@cupakromer cupakromer Merge pull request #1431 from jamelablack/patch-1
Update README.md
735c5f0
@cupakromer cupakromer Merge pull request #1432 from jamelablack/patch-2
Rename code_of_conduct.md to CODE_OF_CONDUCT.md
20103af
@cupakromer cupakromer Update links in readme. 4fbb4aa
Commits on Aug 01, 2015
@cupakromer cupakromer Updated travis build scripts (from rspec-dev) b79233f
@cupakromer cupakromer Merge pull request #1434 from rspec/update-travis-build-scripts-2015-…
…08-01-for-master

Updates from rspec-dev (2015-08-01)
abfd160
@jdax jdax Resolves issue #1044. Adding custom content types to feature, request…
…, controller specs.
895e6bb
@jdax jdax Updating request_spec to accept HTTP_ACCEPT and ACCEPT for Rails 3 an…
…d 4. #1044
fa81ef6
@jdax jdax Clarifying lack of support for 3.0. #1044 7159cd5
@jdax jdax Removing spec for JSON since Capybara will not work with it. Specifie…
…d this in md above. #1044
b6e4f49
@jdax jdax Merge branch 'master' of https://github.com/rspec/rspec-rails e19524b
@cupakromer cupakromer Merge pull request #1435 from jdax/master
Resolves issue #1044. Adding custom content types to feature, request…
6883d89
@cupakromer cupakromer Whitespace only update [ci skip] 70e9f7a
@jdax jdax Resolves #1430. Moving config.include's 081276e
@jdax jdax Merge branch 'master' of https://github.com/rspec/rspec-rails 459909c
@jdax jdax Note fix in Changelog. [ci skip] 7c54346
@cupakromer cupakromer Merge pull request #1436 from jdax/master
Resolving #1430 by relocating
5836988
@AEgan AEgan add whitespace checks and fix end of line whitespace
This adds the file spec/rspec/rails_spec.rb to check for whitespace problems
using the RSpec::Support::WhitespaceChecks module from PR #232 in rspec-support.
This also removes trailing whitespace from three files in the features directory
cefaf2d
@jamelablack jamelablack Removed " " in regex bd815d3
@jamelablack jamelablack Note fix in bug log.
[ci skip]
f36d42a
Commits on Aug 02, 2015
@AEgan AEgan modify error message when redirected but expecting to render a template 48a663a
@AEgan AEgan Add yard doc and description in have_rendered.rb, add more
descriptive param name in spec
9e5671f
@cupakromer cupakromer Merge pull request #1438 from AEgan/whitespace-fix
add whitespace checks and fix end of line whitespace
f1641c7
@cupakromer cupakromer Merge pull request #1439 from jamelablack/regex_bug_fix
Bug fix: removed spaces in regex
9ca9059
@AEgan AEgan add enhancement description to changelog [ci skip] c0e5376
@cupakromer cupakromer Merge pull request #1440 from AEgan/redirect-render-message
modify error message when redirected but expecting to render a template
85fe74b
Commits on Aug 03, 2015
@cupakromer cupakromer Whitespace only update [ci skip] cb2dda8
Commits on Aug 07, 2015
@ahacop ahacop Add explicit access control tags to docs
Prior to the commit, docs for both RSpec::Rails::Matchers#be_a_new and
RSpec::Rails::Matchers#be_new_record incorrectly indicated that the
methods were private.

This commit corrects this issue, following the pattern used here:
https://github.com/rspec/rspec-rails/blame/1fb6f9f642e887df1b1ee344594de02d7de3b3fe/lib/rspec/rails/matchers/have_http_status.rb#L329
(f6c277f)

Fixes #1413
a5eb2d2
@JonRowe JonRowe Merge pull request #1444 from ahacop/access-control-documentation-fix
Add explicit access control tags to docs
d339d7e
Commits on Aug 11, 2015
@JonRowe JonRowe Updated travis build scripts (from rspec-dev) fb08799
Commits on Aug 12, 2015
@JonRowe JonRowe Merge pull request #1445 from rspec/update-travis-build-scripts-2015-…
…08-11-for-master

Updates from rspec-dev (2015-08-11)
fc33b50
Commits on Sep 02, 2015
@zetter zetter Ensure format is in the type that rails expects
Rails expects value of the `:format` option be a symbol. It filters
formats against `Mime::SET.symbols` so formats which are unknown
(or are known but are of an unexpected type) are not used in cache keys
for the Rails' `ActionView::Resolver::Cache`. This made the resolver
cache unusable when there was multiple templates with the same name but
different formats and was the reason the cache was disabled in
rspec-rails [1].

This isn't the only way of fixing this problem- for example Rails could
be changed to ensure symbols aren't compared with strings as was
suggested in [2], but I feel that it's rspec-rails' responsibility
to work with the existing Rails API.

[1] #864
[2] rails/rails#13461
e2ec0e7
@zetter zetter Speed up view specs by re-enabling resolver cache
The caching was turned off in [1] because different formats were being
cached under the same key. I believe the need to do this was removed
in the previous commit.

This reduces the time it takes to run FutureLearn’s view specs by 50%.

I think it’s sensible to use the view resolver cache during tests because
it’s normally on between requests in other environments including when
creating tests with `ActionView::TestCase` in a new Rails application.
It looks like it was only turned off in rspec-rails to work around this
caching issue.

I haven't added any test coverage in this change since it feels like
it would be testing a negative (the resolver cache isn't cleared).

[1] #864
892d501
Commits on Sep 15, 2015
@f1sherman f1sherman fix link to the Code of Conduct from the Contributing guide 245f1c6
@JonRowe JonRowe Merge pull request #1456 from f1sherman/fix-code-of-conduct-link
fix link to the Code of Conduct from the Contributing guide
819a697
Commits on Sep 18, 2015
@soulcutter soulcutter Add option to add rails gems to exclusion filters
Rails in backtraces can get quite spammy, and the configuration option
to `filter_gems_from_backtrace` is not well-known since it is not found
in the generator's `rails_helper.rb`.

This adds `filter_rails_from_backtrace!` as a convenience method for
nixing rails gems in the backtrace and adds it to `rails_helper.rb` to
raise awareness.
570911a
Commits on Sep 19, 2015
@soulcutter soulcutter Clean up some rubocop offenses 8118b91
Commits on Sep 20, 2015
@JonRowe JonRowe Merge pull request #1458 from rspec/rails-exclusion-filters
Rails exclusion filters
efe7c53
@JonRowe JonRowe changelog for #1458
[skip ci]
93c38d8
@soulcutter soulcutter Merge pull request #1452 from Futurelearn/faster-view-specs
Halve the time it takes to run view specs by enabling the resolver cache
af78962
@soulcutter soulcutter Changelog for #1452 c1de0e2
Commits on Sep 30, 2015
@maclover7 maclover7 Sync up Readme footer with other repos 9f35459
@JonRowe JonRowe Merge pull request #1463 from maclover7/patch-1
Sync up Readme footer with other repos
572a1f2
Commits on Oct 02, 2015
@dcrec1 dcrec1 update rails helper description for ActiveRecord::Migration.maintain_…
…test_schema!
3d86a7b
Commits on Oct 06, 2015
@JonRowe JonRowe Unify styles
[skip ci]
51bc206
@JonRowe JonRowe Rename License.txt to License.md f9e8709
@morgoth morgoth Removed trailing whitespaces from License file 20f056f
@JonRowe JonRowe Merge pull request #1465 from morgoth/fix-license-whitespaces
Removed trailing whitespaces from License file
9845ca9
@morgoth morgoth Add have_enqueued_jobs matcher 2b1b9d4
@JonRowe JonRowe list copyrights 6bf2221
@JonRowe JonRowe Merge pull request #1462 from dcrec1/master
Update rails helper description for maintain_test_schema!
b13dd48
Commits on Oct 07, 2015
@JonRowe JonRowe pin rack-cache on ruby < 2.0.0 b282278
@JonRowe JonRowe correct case of license 588988d
@JonRowe JonRowe Merge pull request #1468 from rspec/fix_build
Pin rack-cache on Ruby < 2
be9263e
@morgoth morgoth Improve error messages wording 6a7bfc5
@morgoth morgoth Change have_enqueued_jobs usage UI b35dc1c
Commits on Oct 08, 2015
@morgoth morgoth change to singular matcher name 2ea1754
Commits on Oct 09, 2015
@JonRowe JonRowe Merge pull request #1464 from morgoth/active-job-matchers
Add have_enqueued_jobs matcher
cf8b915
@JonRowe JonRowe Changelog for #1464
[skip ci]
078b29f
Commits on Oct 15, 2015
Dave Marr Fix warning in generate example of Getting Started
Fixes #1475
c0882f0
@JonRowe JonRowe Merge pull request #1476 from marr/fix-warning-in-doc-example
Fix warning in generate example of Getting Started
c3ac231
Commits on Oct 23, 2015
@morgoth morgoth Add more methods to have_enqueued_job matcher ebe3867
@soulcutter soulcutter Merge pull request #1480 from morgoth/improve-aj-matcher
Add more methods to have_enqueued_job matcher
3fa4d25
Commits on Oct 25, 2015
@JonRowe JonRowe label Rspec as private (note lower case s) 112a16d
@JonRowe JonRowe fix visibility with rspec-rails modules
A lot of these modules are for public use, but were being mislabled as
private for some reason, this prevents that by explicity labelling those
with normal comments as @api public, and thus their method are restored
too.
4a2a078
@JonRowe JonRowe Merge pull request #1479 from rspec/label_Rspec_as_private
Label Rspec as @private for docs, update other modules visibility
98ce767
Commits on Nov 10, 2015
@morgoth morgoth Added feature specs for have_enqueued_job matcher efc8f03
@soulcutter soulcutter Merge pull request #1486 from morgoth/have_enqueued_job-feature-spec
Added feature specs for have_enqueued_job matcher
4696404
Commits on Nov 12, 2015
@myronmarston myronmarston Update changelog for v3.4.0 [ci skip] 2c1abc6
@myronmarston myronmarston Release v3.4.0 e52281c
@myronmarston myronmarston Bump version to 3.5.0.pre [ci skip] 947e7ed
Commits on Nov 13, 2015
@morgoth morgoth Throw descriptive error when have_enqueued_job matcher is used with n…
…on test adapter
e327b00
@JonRowe JonRowe Merge pull request #1489 from morgoth/have_enqueued_job-descriptive-e…
…rror

Throw descriptive error when have_enqueued_job matcher is used with non test adapter
f0005ec
Commits on Nov 18, 2015
@JonRowe JonRowe pin nokogiri until fixed 7e6d20d
@JonRowe JonRowe pin nokogiri correctly f8a844d
@JonRowe JonRowe 1.9.2 requires a specific version of nokogiri ed483be
Commits on Nov 22, 2015
@jasnow jasnow Changed Gemfile to include nokogiri 1.6.6.4 as possible 377c363
@samphippen samphippen Merge pull request #1493 from jasnow/master
Fixed Travis Run: Changed Gemfile to permit nokogiri 1.6.6.4 upgrade
6c75c64
@JonRowe JonRowe setup travis to run rails 5 ec76356
@JonRowe JonRowe remove deprecation warning for fixtures b8bd527
@JonRowe JonRowe change from controller::test_response to dispatch::test_response 0da7c86
@JonRowe JonRowe Allow Rails 5 to fail for now 8581933
@samphippen samphippen Merge pull request #1485 from rspec/attempt_to_run_rails_5
Setup to run Rails 5 builds, and fix a few issues.
b4c00c4
Commits on Nov 29, 2015
@samphippen samphippen Continue to improve our nokogiri support specification.
In [this pr](#1493) we got a
quick fix to our broken builds on travis due to nokogiri 1.6.6.4 and
1.6.6.3 not working on travis. Now that nokogiri is releasing new
versions, we want to continue to get them. This patch ensures we don't
get the versions that don't work on travis, but does give us new
versions.
32da7fa
Commits on Nov 30, 2015
@JonRowe JonRowe these versions of nokogiri don't build on travis df04087
Commits on Dec 01, 2015
@JonRowe JonRowe Merge pull request #1497 from rspec/samphippen/nokogiri-versions
Continue to improve our nokogiri support specification.
e27a461
Commits on Dec 06, 2015
@pdswan pdswan allow helper module specs to spec internal classes, fix #1339 686b1be
@pdswan pdswan address compatibility with Rails 3.x ae6ff7b
Commits on Dec 07, 2015
@JonRowe JonRowe Updated common markdown files (from rspec-dev) [ci skip] da4c711
@myronmarston myronmarston Merge pull request #1500 from rspec/update-common-markdown-files-2015…
…-12-07-for-master

Updates from rspec-dev (2015-12-07)
67759ba
Commits on Dec 10, 2015
@samphippen samphippen Merge pull request #1499 from rspec/fix-helper-specs-with-internal-cl…
…asses

Fix helper specs with internal classes
b2d6f8e
@deivid-rodriguez deivid-rodriguez Use Rails 4.2 series for tests
This has the benefit of not skipping ActiveJob tests by default (only
included from Rails 4.2).
8144fa7
@deivid-rodriguez deivid-rodriguez Allow using latest Rake 0b1b729
@deivid-rodriguez deivid-rodriguez Fix typo c382c6d
@samphippen samphippen Add a changelog entry for #1499
[ci skip]
d3d7e79
Commits on Dec 11, 2015
@deivid-rodriguez deivid-rodriguez Fix some warnings 0720ecf
@deivid-rodriguez deivid-rodriguez Don't check for bindir existence
Otherwise it will fail if the directory is not there by default (Rails
3). The folder will be automatically created when creating the binstubs
if not already there.
5b1f6fa
@deivid-rodriguez deivid-rodriguez Fix case for License.md file
To prevent

```
rspec-rails at /home/travis/build/rspec/rspec-rails did not have a valid
gemspec. This prevents bundler from installing bins or native
extensions, but that may not affect its functionality.
The validation message from Rubygems was:
  ["License.md"] are not files
```
dd8aedc
@deivid-rodriguez deivid-rodriguez Reuse script to install gems 0de0419
@samphippen samphippen Merge pull request #1502 from deivid-rodriguez/development_improvements
Development improvements
05a1d7f
Commits on Dec 15, 2015
@samphippen samphippen Warn if a fixture method is called from a before(:context) block.
Fixes #1442.

The basic approach here is to capture the addition of the fixture
methods to the example group instance and then monkeypatch them. The
monkeypatch checks to see if we're currently in a before(:context) hook
and if we are then it prints a warning and doesn't invoke the method.

The warning here is a little sparse at the moment, and I'd like to make
it more clear. One thing that's a little gross about this implementation
is that it uses the inspect string of the example group to determine if
we're in a before(:context) hook. As far as I can tell there isn't a
better way to make that determination, but maybe someone's got a clever
trick.
7cb796d
@samphippen samphippen Add a changelog entry for #1501
Closes #1442

[ci skip]
235d97c
@JonRowe JonRowe Merge pull request #1501 from rspec/samphippen/bugfix/1442
Warn if a fixture method is called from a `before(:context)` block.
a6bdb46
Commits on Dec 16, 2015
@timoschilling timoschilling Remove unused `@verb_to_path_map` from RouteToMatcher 8802bb8
@samphippen samphippen Merge pull request #1505 from rspec/timoschilling/1484
Remove unused `@verb_to_path_map` from RouteToMatcher
2d864f8
@iamryo iamryo Fix URL helpers via the `extra_params` API to view specs.
This enables URL helpers to work in view specs via the `extra_params`
API. This API updates the controller's path information via a writer and
allows the user to read path information out of the controller.
51cc863
@samphippen samphippen Add a changelog entry for #1402 adf9a4d
Commits on Dec 17, 2015
@samphippen samphippen Merge pull request #1402 from sarahmei/expose_path_to_view_specs
Expose path to view specs
e566410
Commits on Dec 19, 2015
@samphippen samphippen Add explicit git master web console dependency
This is done because rails 5 needs a newer version of rails console than
will be installed by the implicit dependencies resolved via rubygems. It
is also only added to the development group because we do not want
webconsole to get in the way of any of the specs that we run.
0e5d559
@samphippen samphippen Fix up dependencies for the example app.
We need the rails controller testing gem to be able to test the sample
app. We also don't want it to run web console at all.
6d6af2f
@samphippen samphippen Switch mailer examples on rails version.
Rails 5 changes the class name generated for mailers from looking like
`Thing` to looking like `ThingMailer`. Our cukes depend on this name,
and so break as is. Here, I've added two tags, `@pre_rails_5` and
`@post_rails_5`.

The modification to the rakefile changes how we execute cukes based on
the rails version, filtering to the correct cukes.
4e73e71
@samphippen samphippen Fixup response code handling in `have_http_status`.
This now consistently calls `.to_i` on response codes, which ensures
they're always an integer (accross rails versions). Additionally I
replaced a number of `333` codes with `308`s. The reasoning for this is
that rack no longer accepts non-spec 3xx codes in it's `redirect?`
methods, which breaks our tests.
6e252ee
@samphippen samphippen Change render_views specs to match more generic headers.
In Rails 5, the word "Listing" has been removed from the autogenerated
scaffold header, so here we match with a simple regex.
625fe44
@samphippen samphippen Fixup mailer spec generators for Rails 5.
Rails 5 now automatically appends the word `Mailer` to generated mailer
classes. We now have to do that too.
7a13bf1
@samphippen samphippen Setup compatability with the `rails-controller-testing` gem.
This fixes a number of spec types, and requires the added setup lines.
As a note, this is a soft, not hard dependency. We don't get automatic
compatability. Instead, users will have to add the gem to their Gemfile
if they want that functionality.
e4bee71
@samphippen samphippen Fix up view example groups.
`controller.request.path_parameters` is no longer able to be directly
assigned to, but should instead be mutated. Here, we take what we were
doing before with the assignment and doing a reverse merge instead,
which has the same affect.
8fda9e9
@samphippen samphippen Fixup have_http_status matcher header assignment.
We now have to mutate, instead of assigning, headers in the resp.headers
property here.
3bf5af1
@samphippen samphippen Fixup various fakes for Rails 5 testing. b795447
@samphippen samphippen Add Rails 5.0.0.beta1 to the travis build. 275905d
Liss McCabe Singularize classes for feature names
Fixes issue #1403
a597367
Liss McCabe Add `--singularize` flag on feature generators 028d074
@samphippen samphippen Add a changelog entry for #1503
Closes #1403
bf9de9a
@samphippen samphippen Merge pull request #1508 from rspec/1403_singular_generator
#1503 with changelog.
b1dff7f
Commits on Dec 24, 2015
@JonRowe JonRowe Merge pull request #1492 from rspec/rails-5-support-patches
Rails 5 support patches
fef96ff
@JonRowe JonRowe prevent bad version of nokogiri 906a826
@JonRowe JonRowe Merge pull request #1510 from rspec/pin_nokogiri
Prevent bad version of nokogiri and fix build
7f2b695
Commits on Dec 30, 2015
@myronmarston myronmarston Nokogiri 1.6.7 will not install for us, either. 8417d44
Commits on Jan 01, 2016
@yujinakayama yujinakayama Updated travis build scripts (from rspec-dev) 491a192
@yujinakayama yujinakayama Run MRI 2.3.0 on Travis CI 0bbee03
Commits on Jan 03, 2016
@yujinakayama yujinakayama Pin nokogiri to 1.6.7.1 aad8296
Commits on Jan 04, 2016
@yujinakayama yujinakayama Remove debugger gem from example app Gemfile
It's essentially not needed for our test and tend to cause installation problem.
e8202a2
@yujinakayama yujinakayama Merge pull request #1516 from rspec/update-travis-build-scripts-2016-…
…01-01-for-master

Updates from rspec-dev (2016-01-01)
c9fbfee
@yujinakayama yujinakayama Updated travis build scripts (from rspec-dev) 7b5451e
Commits on Jan 05, 2016
@soulcutter soulcutter Merge pull request #1518 from rspec/update-travis-build-scripts-2016-…
…01-04-for-master

Updates from rspec-dev (2016-01-04)
9bcc8a0
@Ferdy89 Ferdy89 Do not leak TestUnit specific methods after Rails 4
* TestUnit requires the build_message method to be defined for its
  assertions to work properly. After Rails 4, Minitest is used instead
  of TestUnit so the method should not be included anymore. This is
  problematic because when using RSpec configured with

      config.expect_with :test_unit

  the TestUnit assertions try to call build_message on the
  MinitestAssertionAdapter which will crash.
255f08d
Commits on Jan 06, 2016
@JonRowe JonRowe Updated travis build scripts (from rspec-dev) 4cf4e95
@myronmarston myronmarston Merge pull request #1521 from rspec/update-travis-build-scripts-2016-…
…01-06-for-master

Updates from rspec-dev (2016-01-06)
9eee11a
Commits on Jan 08, 2016
@yujinakayama yujinakayama Use RSpec::Support::ComparableVersion for capybara version check
... so that we can remove RSpec::Support::VersionChecker in rspec-support.
2747b30
@JonRowe JonRowe Merge pull request #1523 from rspec/replace-version-checker-with-comp…
…arable-version

Use RSpec::Support::ComparableVersion for capybara version check
b2ac99c
Commits on Jan 14, 2016
@eliotsykes eliotsykes Favor https: over git: protocol remotes
From Bundler docs on Security:

> http:// and git:// URLs are insecure. A man-in-the-middle attacker
could tamper with the code as you check it out, and potentially supply
you with malicious code instead of the code you meant to check out.
Because the :github shortcut uses a git:// URL in Bundler 1.x versions,
we recommend using using HTTPS URLs or overriding the :github shortcut
with your own HTTPS git source.

Source: http://bundler.io/git.html
cf09a38
@JonRowe JonRowe Merge pull request #1526 from eliotsykes/favor-https-over-git-protocol
Favor https: over git: protocol remotes
d108631
Commits on Jan 15, 2016
@soulcutter soulcutter Merge pull request #1512 from Ferdy89/do_not_leak_test_unit_methods_a…
…fter_rails_4

Do not leak TestUnit specific methods after Rails 4
4445423
@soulcutter soulcutter Add changelog entry for #1512 6f06b28
Commits on Jan 26, 2016
@yujinakayama yujinakayama Use the same version of nokogiri in example app
... to fix the installation problem on Travis CI.
cde2444
@samphippen samphippen Allow failure of `~> 3.2.17` for the moment.
This is because the security release of `3.2.22.1` was not correctly
tested against 1.8.7 which means that our build will not pass against
this ruby. /cc @pixeltrix.
49536d3
@samphippen samphippen Merge pull request #1534 from rspec/use-same-version-of-nokogiri-in-e…
…xample-app

Use the same version of nokogiri in example app
a664278
Commits on Jan 27, 2016
@pixeltrix pixeltrix Fix empty template rendering for Rails 4.2.5.1
Closes #1532.

Refactor the template rendering overrides in controller specs to be more
compatible with the Action View public api. Previously `EmptyTemplatePathSetDecorator`
overrode the `find_all` method to wrap a path set. However `ActionView::PathSet`
is not public api so instead create a subclass of `ActionView::FileSystemResolver`
to return an empty template and treat `view_paths` as an array of string-like objects.
80637fc
@samphippen samphippen Merge pull request #1535 from pixeltrix/fix-empty-template-resolver
Fix empty template rendering for Rails 4.2.5.1
44e5b8a
Commits on Jan 31, 2016
@pixeltrix pixeltrix Fix performance regression with empty template rendering
Closes #1537.

The change in 80637fc introduced a performance regression because the
template lookup cache was being lost every time an example was run.

This commit fixes the problem by caching the EmptyTemplateResolver
instances between example runs in a hash indexed by the path string.
92ab9d2
Commits on Feb 01, 2016
@JonRowe JonRowe Merge pull request #1544 from pixeltrix/fix-3-4-1-performance-regression
Fix performance regression with empty template rendering
ec1bbc6
@JonRowe JonRowe forward port changelog for 3.4.1 e60fefe
@JonRowe JonRowe changelog for #1544 ccf4af1
@JonRowe JonRowe update changelog f370656
@JonRowe JonRowe limit 3.2.22.1 on Ruby 187 5d69354
Commits on Feb 02, 2016
@JonRowe JonRowe Merge pull request #1540 from rspec/fix_187_rails_3_2_22_1
Prevent Rails 3.2.22.1 on Ruby 1.8.7
fae9cf4
@JonRowe JonRowe update changelog for #1540
[skip ci]
463f7d1
@JonRowe JonRowe forwardport release 3.4.2
[skip ci]
f98afa1
Commits on Feb 03, 2016
Sergey Pchelintsev improve docs about metadata `:type` c7f7040
@JonRowe JonRowe Merge pull request #1543 from jalkoby/master
Improve the documentation about automatic metadata
74131b2
Commits on Feb 06, 2016
@samphippen samphippen Move travis from using Rails 5 beta1 to using beta2. 40487b8
@samphippen samphippen Merge pull request #1547 from rspec/rails-5-beta-2-travis
Move travis from using Rails 5 beta1 to using beta2.
afba825
@samphippen samphippen Release RSpec Rails 3.5.0.beta1 f25b87b
@samphippen samphippen Return RSpec rails to 3.5.0.pre 8117cbd
Commits on Feb 07, 2016
@JonRowe JonRowe Fixed issue with installing nokogiri in sample apps 41de594
@JonRowe JonRowe add negated render template examples eb51403
@samphippen samphippen Merge pull request #1548 from rspec/add_negated_template_examples
Add negated template examples
8aef271
Commits on Feb 08, 2016
@Alwahsh Alwahsh Let float have an incrementing number
If a model has 2 float attributes, the auto generated
tests are failing ones because of duplicate value.
50b4ec8
Commits on Feb 09, 2016
@Alwahsh Alwahsh Add some tests for generated scaffold index 6b17043
@JonRowe JonRowe Merge pull request #1550 from Alwahsh/fix_scaffolds
Fixing index view tests for a scaffold with multiple float attributes
fa9a67b
@JonRowe JonRowe Changelog for #1550
[skip ci]
897d2a5