Use controller as implicit subject in ControllerExampleGroup? #223

Closed
paulrosania opened this Issue Sep 29, 2010 · 5 comments

Comments

Projects
None yet
2 participants
@paulrosania
Contributor

paulrosania commented Sep 29, 2010

In Rails 1.X, controller specs defaulted to the controller returned from the controller method:

def inherited(klass) # :nodoc:
  ...
  klass.subject { controller }
  ...
end

Was this intentionally removed from RSpec2, or can I submit a patch for it?

Here's the RSpec 1.X changeset: dchelimsky@5d114beefcaabdb225de9f83f9406407f1df73a0

@dchelimsky

This comment has been minimized.

Show comment Hide comment
@dchelimsky

dchelimsky Sep 29, 2010

Owner

Not removed intentionally. Patch away.

Owner

dchelimsky commented Sep 29, 2010

Not removed intentionally. Patch away.

@paulrosania

This comment has been minimized.

Show comment Hide comment
@paulrosania

paulrosania Sep 30, 2010

Contributor

Cool! Patch: paulrosania@4d63ccb

Contributor

paulrosania commented Sep 30, 2010

Cool! Patch: paulrosania@4d63ccb

@paulrosania

This comment has been minimized.

Show comment Hide comment
@paulrosania

paulrosania Sep 30, 2010

Contributor

ControllerExampleGroup uses controller as the implicit subject by default

Restores functionality from RSpec 1.X. Hat tip to jferris for the original
patch. (Closed by 1a99f59)

Contributor

paulrosania commented Sep 30, 2010

ControllerExampleGroup uses controller as the implicit subject by default

Restores functionality from RSpec 1.X. Hat tip to jferris for the original
patch. (Closed by 1a99f59)

@dchelimsky

This comment has been minimized.

Show comment Hide comment
@dchelimsky

dchelimsky Sep 30, 2010

Owner

Merged: 1a99f59

Owner

dchelimsky commented Sep 30, 2010

Merged: 1a99f59

@paulrosania

This comment has been minimized.

Show comment Hide comment
@paulrosania

paulrosania Sep 30, 2010

Contributor

Thanks!!

Contributor

paulrosania commented Sep 30, 2010

Thanks!!

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment