Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveSupport::Notifications.unsubscribe don't work #44

Closed
hasimo opened this issue May 6, 2010 · 2 comments
Closed

ActiveSupport::Notifications.unsubscribe don't work #44

hasimo opened this issue May 6, 2010 · 2 comments

Comments

@hasimo
Copy link
Contributor

hasimo commented May 6, 2010

ActiveSupport::Notifications.subscribe's argment is changed on this commit
http://github.com/rails/rails/commit/731d4392e478ff5526b595074d9caa999da8bd0c

Please backport.
@dchelimsky
Copy link
Contributor

Thanks for the heads up. This is due to a monkey patch currently in rspec-rails that we should be able to remove after the next rails-3 release (i'm assuming that will be an rc).

In the mean time, I'm patching the monkey patch to support tearing down subscriptions using the old names and the new names. Coming shortly.

@dchelimsky
Copy link
Contributor

Unsubscribe from notifications in AC::TC monkey patch to support
rails-3.0.0.beta.3 and edge as well.

Closed by ccb61c5.

jamesottaway pushed a commit to jamesottaway/rspec-rails that referenced this issue Mar 30, 2015
@dchelimsky
Unsubscribe from notifications in AC::TC monkey patch to support
ccb61c5 
rails-3.0.0.beta.3 and edge as well.

Closes rspec#44.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dchelimsky @hasimo