Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Support rspec-core's 3.0 deprecation of `example` outside a hook or let #782

Closed
alindeman opened this Issue · 4 comments

2 participants

@alindeman
Collaborator

See more commentary here: rspec/rspec-core#666 (comment)

2.14 and 2.99 are OK, but rspec-rails 3.0 (master) needs updating.

@thomas-holmes

A simple change to Capybara has put all tests back into the green but I assume I need to actually add some new tests to rspec-rails and change some behavior but I'm not quite sure what or where it is yet. Maybe I don't quite understand the title?

I think I just put it together while I was away. Do you mean it should also pass the correct value to the block given to describe/context?

@alindeman
Collaborator

I think it probably makes sense to solve the issue with Capybara first, because that's causing a lot of red. Let's loop back on this afterward and see if anything is still failing.

To get that working, I need to get something like RSpec.current_example out the door. See rspec/rspec-core#666 for details.

Sorry about this not being more actionable right now :(

@thomas-holmes

No problem. I can open up an issue against Capybara with the change. It removed all red in my local tests.

@alindeman
Collaborator

The only remaining issue that I know of is jnicklas/capybara#1122. Closing this to focus on that one.

@alindeman alindeman closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.