Extract `have(n).records` support #808

Closed
alindeman opened this Issue Aug 17, 2013 · 3 comments

Projects

None yet

3 participants

@alindeman

Move the Rails-specific functionality to the rspec-collection_matchers gem.

@myronmarston
RSpec member

Alternately, the rails-specific bits could move from rspec-rails into the new rspec-collection_matchers gem, where it would be conditionally loaded if in a rails (or ActiveRecord or ActiveModel or whatever is needed) context.

@alindeman

Cool. That's what I meant (but didn't say particularly eloquently) in the description of the issue. I like that strategy better.

@soulcutter
RSpec member

This needs to happen sooner rather than later since rspec/rspec-expectations#293 got merged in. The build is currently broken.

activesupport-3.2.13/lib/active_support/dependencies.rb:251:in `require': cannot load such file -- rspec/matchers/built_in/have (LoadError)
@soulcutter soulcutter referenced this issue in rspec/rspec-collection_matchers Aug 19, 2013
Merged

Extract Rails extension to have matcher #5

@soulcutter soulcutter added a commit that referenced this issue Aug 19, 2013
@soulcutter soulcutter Remove the have extension
This functionality was extracted into
rspec/rspec-collection_matchers#5

Fixes #808
7fd43e9
@JonRowe JonRowe closed this in #810 Sep 9, 2013
@soulcutter soulcutter added a commit to rspec/rspec-collection_matchers that referenced this issue Feb 19, 2014
@soulcutter soulcutter Extract Rails extension to have matcher 6a09c17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment