Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out default auto-loading of spec/support #1137

Merged
merged 2 commits into from Aug 4, 2014

Conversation

@cupakromer
Copy link
Member

@cupakromer cupakromer commented Aug 3, 2014

Continuing with the effort to help RSpec suites run faster in isolation;
disable the previously default autoloading of spec/support files. With
larger suites, this autoloading had the tendency to load more extraneous
configurations than necessary.

The suggested alternative is to manually require any necessary support
files in the *_spec.rb files. Since RSpec has already added spec/ to
the load path, this is a simple require:

require 'support/some_file'

This has the pleasant (depending on your point of view) side-effect or
making one think critically about how support files are defined.

Close #1106

cupakromer added 2 commits Aug 3, 2014
Continuing with the effort to help RSpec suites run faster in isolation;
disable the previously default autoloading of `spec/support` files. With
larger suites, this autoloading had the tendency to load more extraneous
configurations than necessary.

The suggested alternative is to manually require any necessary support
files in the `*_spec.rb` files. Since RSpec has already added `spec/` to
the load path, this is a simple require:

    require 'support/some_file'

This has the pleasant (depending on your point of view) side-effect or
making one think critically about how support files are defined.

Close #1106
@myronmarston
Copy link
Member

@myronmarston myronmarston commented Aug 4, 2014

LGTM

JonRowe added a commit that referenced this pull request Aug 4, 2014
Comment out default auto-loading of `spec/support`
@JonRowe JonRowe merged commit defb19a into master Aug 4, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@JonRowe JonRowe deleted the comment-out-default-support-loading branch Aug 4, 2014
@JonRowe
Copy link
Member

@JonRowe JonRowe commented Aug 4, 2014

👍 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants