Update gem description to include Rails 5. #1653

Merged
merged 1 commit into from Jul 4, 2016

Projects

None yet

3 participants

@benpickles
Contributor

No description provided.

@samphippen
Member

@myronmarston @JonRowe how do you feel about bumping to 3.5.1 for this and release?

@myronmarston
Member

I think it definitely makes sense to cherry-pick this to the 3-5-maintenance branch to be included in the next release, but it feels unnecessary to cut a release with just this. This doesn't affect any functionality, after all -- it's basically just a glorified comment.

@samphippen
Member

@myronmarston that seems good. I'll do that :)

@samphippen
Member

Closing in favour of #1654

@samphippen samphippen closed this Jul 4, 2016
@myronmarston
Member

@samphippen this commit should be included in master and 3-5-maintenance, so why not merge this one to get it in master? Usually we just cherry-pick the commits to the maint branch instead of opening another PR (unless we are concerned about it causing a failing build in the branch).

@samphippen
Member

Ah right. Yes. Sorry, Misunderstood what you meant by cherry pick. I'll merge this one in now.

@samphippen samphippen reopened this Jul 4, 2016
@samphippen samphippen merged commit fc4f530 into rspec:master Jul 4, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@samphippen
Member

@benpickles thanks for this! it's now merged into all the relevant RSpec branches :)

@benpickles
Contributor

My pleasure.

Thanks for maintaining such a great library, it's nice to watch development in the open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment