New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gem description to include Rails 5. #1653

Merged
merged 1 commit into from Jul 4, 2016

Conversation

Projects
None yet
3 participants
@benpickles
Contributor

benpickles commented Jul 4, 2016

No description provided.

@samphippen

This comment has been minimized.

Show comment
Hide comment
@samphippen

samphippen Jul 4, 2016

Member

@myronmarston @JonRowe how do you feel about bumping to 3.5.1 for this and release?

Member

samphippen commented Jul 4, 2016

@myronmarston @JonRowe how do you feel about bumping to 3.5.1 for this and release?

@myronmarston

This comment has been minimized.

Show comment
Hide comment
@myronmarston

myronmarston Jul 4, 2016

Member

I think it definitely makes sense to cherry-pick this to the 3-5-maintenance branch to be included in the next release, but it feels unnecessary to cut a release with just this. This doesn't affect any functionality, after all -- it's basically just a glorified comment.

Member

myronmarston commented Jul 4, 2016

I think it definitely makes sense to cherry-pick this to the 3-5-maintenance branch to be included in the next release, but it feels unnecessary to cut a release with just this. This doesn't affect any functionality, after all -- it's basically just a glorified comment.

@samphippen

This comment has been minimized.

Show comment
Hide comment
@samphippen

samphippen Jul 4, 2016

Member

@myronmarston that seems good. I'll do that :)

Member

samphippen commented Jul 4, 2016

@myronmarston that seems good. I'll do that :)

@samphippen

This comment has been minimized.

Show comment
Hide comment
@samphippen

samphippen Jul 4, 2016

Member

Closing in favour of #1654

Member

samphippen commented Jul 4, 2016

Closing in favour of #1654

@samphippen samphippen closed this Jul 4, 2016

@myronmarston

This comment has been minimized.

Show comment
Hide comment
@myronmarston

myronmarston Jul 4, 2016

Member

@samphippen this commit should be included in master and 3-5-maintenance, so why not merge this one to get it in master? Usually we just cherry-pick the commits to the maint branch instead of opening another PR (unless we are concerned about it causing a failing build in the branch).

Member

myronmarston commented Jul 4, 2016

@samphippen this commit should be included in master and 3-5-maintenance, so why not merge this one to get it in master? Usually we just cherry-pick the commits to the maint branch instead of opening another PR (unless we are concerned about it causing a failing build in the branch).

@samphippen

This comment has been minimized.

Show comment
Hide comment
@samphippen

samphippen Jul 4, 2016

Member

Ah right. Yes. Sorry, Misunderstood what you meant by cherry pick. I'll merge this one in now.

Member

samphippen commented Jul 4, 2016

Ah right. Yes. Sorry, Misunderstood what you meant by cherry pick. I'll merge this one in now.

@samphippen samphippen reopened this Jul 4, 2016

@samphippen samphippen merged commit fc4f530 into rspec:master Jul 4, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@samphippen

This comment has been minimized.

Show comment
Hide comment
@samphippen

samphippen Jul 4, 2016

Member

@benpickles thanks for this! it's now merged into all the relevant RSpec branches :)

Member

samphippen commented Jul 4, 2016

@benpickles thanks for this! it's now merged into all the relevant RSpec branches :)

@benpickles

This comment has been minimized.

Show comment
Hide comment
@benpickles

benpickles Jul 5, 2016

Contributor

My pleasure.

Thanks for maintaining such a great library, it's nice to watch development in the open.

Contributor

benpickles commented Jul 5, 2016

My pleasure.

Thanks for maintaining such a great library, it's nice to watch development in the open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment