Improve doc about Job specs & Rails versions matrix #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed a new version is available and there is a new system specs feature type. Should I add that one too? |
|
Yes please |
JonRowe
requested changes
Nov 14, 2017
features/directory_structure.feature
Outdated
| - Mailer specs reside in the `spec/mailers` directory | ||
| - Routing specs reside in the `spec/routing` directory | ||
| - Job specs reside in the `spec/jobs` directory | ||
| - [Model specs](../model-specs) reside in the `spec/models` directory |
There was a problem hiding this comment.
For relish these can all just be (model-specs) etc which I'd prefer as it's clearer it will work, could you change them and then I'm happy to merge.
There was a problem hiding this comment.
Sure, I took the syntax from here:
JonRowe
approved these changes
Nov 15, 2017
|
Thanks! |
JonRowe
pushed a commit
that referenced
this pull request
Nov 20, 2017
* Improve doc about Job specs & rails versions matrix * Add System specs information in doc * doc: add links from directory structure feature to other features * doc: simpler links to other features
This was referenced Mar 20, 2018
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
* Improve doc about Job specs & rails versions matrix * Add System specs information in doc * doc: add links from directory structure feature to other features * doc: simpler links to other features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.