Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison of times for `#at` in job matchers. #2304

Merged
merged 1 commit into from Mar 28, 2020

Conversation

@JonRowe
Copy link
Member

JonRowe commented Mar 28, 2020

Prior to 4.0.0 we used to_f to ensure parity of precision with Rails internals this was lost when we added support for date matching, but this restores it for Time objects only.

Thanks to @doits for the work on this, fixes #2299 #2301.

Prior to 4.0.0 we used `to_f` to ensure parity of precision with Rails internals
this was lost when we added support for date matching, but this restores
it for Time objects only.

Co-authored-by: Markus Doits <markus.doits@stellenticket.de>
@JonRowe JonRowe force-pushed the fix-enqueued-at-with-time branch from d2ec1d3 to f345e82 Mar 28, 2020
@pirj
pirj approved these changes Mar 28, 2020
Copy link
Member

pirj left a comment

LGTM!

@JonRowe JonRowe merged commit ee37445 into master Mar 28, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@JonRowe JonRowe deleted the fix-enqueued-at-with-time branch Mar 28, 2020
JonRowe added a commit that referenced this pull request Mar 28, 2020
JonRowe added a commit that referenced this pull request Mar 28, 2020
Fix comparison of times for `#at` in job matchers.
JonRowe added a commit that referenced this pull request Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.