Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back Ruby 2.2 support for Rails 5 #2332

Merged
merged 2 commits into from May 16, 2020
Merged

Add back Ruby 2.2 support for Rails 5 #2332

merged 2 commits into from May 16, 2020

Conversation

@JonRowe
Copy link
Member

JonRowe commented May 12, 2020

No description provided.

@JonRowe JonRowe force-pushed the fix-ruby22 branch 3 times, most recently from 689fb88 to 5227212 May 12, 2020
@JonRowe JonRowe force-pushed the fix-ruby22 branch from cf1dc8f to 28f9597 May 13, 2020
@JonRowe
Copy link
Member Author

JonRowe commented May 13, 2020

@benoittgt I've temporarily suppressed our phantom error as I'd like to do a release to resolve this issue in particular

@benoittgt
Copy link
Member

benoittgt commented May 13, 2020

No problem Jon.

@JonRowe JonRowe force-pushed the fix-ruby22 branch 10 times, most recently from 79b4031 to 80bdca1 May 13, 2020
This was referenced May 15, 2020
@JonRowe JonRowe force-pushed the fix-ruby22 branch 4 times, most recently from cd3e4a8 to 5792824 May 15, 2020
@JonRowe JonRowe force-pushed the fix-ruby22 branch 2 times, most recently from e1bb46f to b705036 May 15, 2020
@benoittgt
Copy link
Member

benoittgt commented May 16, 2020

I am late but if you need some help on this @JonRowe

@JonRowe JonRowe force-pushed the fix-ruby22 branch 2 times, most recently from f341683 to 93c6f8c May 16, 2020
@JonRowe JonRowe force-pushed the fix-ruby22 branch from 93c6f8c to e53d9e6 May 16, 2020
@JonRowe
Copy link
Member Author

JonRowe commented May 16, 2020

I've just been playing whackamole with the Travis build @benoittgt 😂 I think it'll pass now, care to re-review?

.travis.yml Show resolved Hide resolved
end
group.run
group.run(failure_reporter)
expect(failure_reporter.exceptions).to eq []

This comment has been minimized.

Copy link
@benoittgt

benoittgt May 16, 2020

Member

I do not understand why we need the FailureReporter anymore?

This comment has been minimized.

Copy link
@JonRowe

JonRowe May 16, 2020

Author Member

Its included for future debugging, we've had this spec fail before and its really hard to see why without this pattern, I'm going to use it in other places for the same reason.

This comment has been minimized.

Copy link
@benoittgt

benoittgt May 16, 2020

Member

Nice! Maybe we could add a little bit of documentation on the top of file or somewhere?

@JonRowe JonRowe merged commit 0b61a4b into master May 16, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@JonRowe JonRowe deleted the fix-ruby22 branch May 16, 2020
JonRowe added a commit that referenced this pull request May 16, 2020
* Add extra debugging tool for specs expected to pass

* Add back Ruby 2.2 support for Rails 5
@pirj pirj mentioned this pull request Jul 20, 2020
0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.