Rails 3 append_view_paths/prepend_view_path bugfix. #359

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@amerine
amerine commented Apr 28, 2011

In Rails 3 when you use append_view_paths or prepend_view_path on a controller to change the view_path at runtime the views are rendering when render_views is false. This patch adds support to rspec-rails to stop the views from rendering.

@dchelimsky
Member

I was already working on this locally before your last commit, so I'm gonna go w/ the first two and my changes (running suite now).

@dchelimsky
Member

FYI - heading out for the eve so this won't get merged tonight, but I will be merging it in the next day or so.

@amerine
amerine commented Apr 29, 2011

Thanks for taking a looking at this so quickly. This was one of the final bugs we hit during a massive rails 3/rspec2 upgrade.

@dchelimsky dchelimsky added a commit that closed this pull request Apr 29, 2011
@amerine amerine Override append/prepend_view_paths in controller specs
- inject rspec-rails' path delegator resolver
- Closes #359.
39961a0
@dchelimsky
Member

@amerine - thank @srbaker for pinging me about it :)

I made a few changes in the next commit: 7cd0f5e

Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment