Fix rendering deprecations in view specs #529

Merged
merged 1 commit into from Apr 22, 2012

Projects

None yet

4 participants

@jdelStrother

render(:template=>'new.erb') is now deprecated and should be render(:template=>'new', :handlers=>['erb']). This patch takes the default template name supplied in the spec and breaks it up into its separate components before calling render().

See #485 for background.

For some reason I thought just running 'rake' in rspec-dev ran the specs against a variety of rails versions, but scanning through the code I can't see where that's done. So at the moment, this is only tested against 3.2.2 - any tips on testing the others, or do we not care?

@jdelStrother jdelStrother Fix rendering deprecations in view specs
render(:template=>'new.erb') is now deprecated and should be render(:template=>'new', :handlers=>['erb']).  This patch takes the default template name supplied in the spec and breaks it up into its separate components before calling render().
656ff35
@justinko

Thanks for the pull!

This needs to work against all of the Rails versions in our travis config.

Have a look at this page to see how to run against multiple versions.

@jdelStrother

OK, seems fine against all Rails versions except master, which I can't seem to even install at the moment ("Could not find gem 'active_record_deprecated_finders (= 0.0.1) ruby'" when running bundle install)

@dchelimsky dchelimsky merged commit 0336706 into rspec:master Apr 22, 2012
@dchelimsky dchelimsky added a commit that referenced this pull request Apr 22, 2012
@dchelimsky dchelimsky Changelog for #529 [ci skip] 040f6a9
@fcy
fcy commented May 2, 2012

Hi Guys,

I'm new to Ruby/Rails in general. Sorry If I'm asking this on the wrong place or if there's a place where it's already answered. But in which version will this fix be available?

@dchelimsky
Member

@fmcypriano sem problemas. Vai estar incluido na versão 2.10, provavilmente na fim de semana que vem.

@fcy
fcy commented May 2, 2012

@dchelimsky Valeu! Tomei um "susto" com a resposta em português :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment