Fix spacing in install generator template #728

Merged
merged 1 commit into from Apr 6, 2013

Conversation

Projects
None yet
3 participants
Contributor

taiki45 commented Apr 3, 2013

When I generated spec_helper.rb using this gem, I noticed really little things about spacing. It is really little thing and everyone might not care about it.

Thank you for great gem.

Contributor

alindeman commented Apr 3, 2013

I've thought about this before, thanks for bringing it up. Can you also add a space after the { too?

Contributor

taiki45 commented Apr 3, 2013

Sure. If you noticed anything else, please tell me.

Owner

samphippen commented Apr 5, 2013

@taiki45 would you mind rebasing these commits into one? I don't think this needs to be in two commits.

Contributor

taiki45 commented Apr 5, 2013

@samphippen I'm sorry. I think so too.

Contributor

taiki45 commented Apr 5, 2013

@samphippen It looks done.

Owner

samphippen commented Apr 5, 2013

@taiki45 looks good to me. Thanks very much. @alindeman do you think this needs a changelog entry?

Contributor

alindeman commented Apr 6, 2013

Let's add one to give @taiki45 some credit :) Want to wrap it up, @samphippen ?

Owner

samphippen commented Apr 6, 2013

Sure :)

Sent from my phone please excuse my brevity.

On 6 Apr 2013, at 17:18, Andy Lindeman notifications@github.com wrote:

Let's add one to give @taiki45 https://github.com/taiki45 some credit :)
Want to wrap it up, @samphippen https://github.com/samphippen ?


Reply to this email directly or view it on
GitHubhttps://github.com/rspec/rspec-rails/pull/728#issuecomment-15998913
.

@ghost ghost assigned samphippen Apr 6, 2013

Owner

samphippen commented Apr 6, 2013

thanks @taiki45. I'm going to merge this now :)

samphippen added a commit that referenced this pull request Apr 6, 2013

@samphippen samphippen merged commit 8e9221a into rspec:master Apr 6, 2013

1 check passed

default The Travis build passed
Details

samphippen added a commit that referenced this pull request Apr 6, 2013

Add a changelog entry for #728.
[ci skip]

Signed-off-by: Sam Phippen <samphippen@googlemail.com>
Contributor

taiki45 commented Apr 7, 2013

Wow, Thank you very much!

samphippen added a commit that referenced this pull request Apr 13, 2013

Add a changelog entry for #728.
[ci skip]

Signed-off-by: Sam Phippen <samphippen@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment