Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Change some version checks to use ActiveRecord. #804

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

dpogue commented Aug 9, 2013

Trying to use ActiveRecord fixtures in my tests for a gem that uses ActiveRecord, but doesn't depend on all of Rails. Currently rspec-rails makes some checks based on ::Rails::VERSION.

This change uses ::ActiveRecord::VERSION for those checks related to ActiveRecord fixtures, allowing fixtures to be used without including Rails.

@dpogue dpogue Change some version checks to use ActiveRecord.
This allow using ActiveRecord fixtures without pulling in all of Rails.
f3d0cb9
Contributor

alindeman commented Aug 9, 2013

Thanks! I think this looks good, but I want to see the entire test suite green. Unfortunately the autotest extraction broke the rspec-rails' test suite for a few days. It's since been fixed, so I rebased your changes and opened #805.

@alindeman alindeman closed this Aug 9, 2013

@alindeman alindeman added a commit that referenced this pull request Aug 10, 2013

@alindeman alindeman Merge branch 'dpogue-rails-deps'
[Closes #805]
[Refs #804]
710fb67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment