Skip to content

Rubinius test unit patch #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2013
Merged

Rubinius test unit patch #871

merged 1 commit into from
Dec 9, 2013

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Dec 9, 2013

If we're going to patch this (not saying we should, we want the least effect on
other Rubies, so only try to do this if there is no test-unit and we think Rubinius
is in play)

@alindeman
Copy link
Contributor

Looks sane to me 👍

@JonRowe
Copy link
Member Author

JonRowe commented Dec 9, 2013

I don't mind merging this to help Rubinius users, @myronmarston, thoughts?

@myronmarston
Copy link
Member

👍

@bf4
Copy link
Contributor

bf4 commented Dec 9, 2013

Looks like there might be a rubysl-rspec gem at some point.. https://github.com/rubysl/rubysl/issues/7

JonRowe added a commit that referenced this pull request Dec 9, 2013
@JonRowe JonRowe merged commit 57c8d42 into master Dec 9, 2013
@JonRowe JonRowe deleted the rubinius_std_lib branch December 9, 2013 20:37
@JonRowe
Copy link
Member Author

JonRowe commented Dec 9, 2013

@bf4 That doesn't affect this particular issue, plus afaik theres no easy load point for the stuff they're talking about.

brixen referenced this pull request in bf4/bf4.github.com Dec 15, 2013
JonRowe added a commit that referenced this pull request Dec 22, 2013
@JonRowe JonRowe mentioned this pull request Dec 22, 2013
JonRowe added a commit that referenced this pull request Dec 22, 2013
alindeman added a commit that referenced this pull request Dec 22, 2013
alindeman added a commit that referenced this pull request Dec 22, 2013
@bf4
Copy link
Contributor

bf4 commented Dec 24, 2013

Per @brixen this should be unnecessary, fwiw bf4/bf4.github.com@92d7445#commitcomment-4865806

@JonRowe
Copy link
Member Author

JonRowe commented Dec 24, 2013

It's necessary because Rails expects test unit to be present, and Rubinius
doesn't seem to include it by default.

This is a work around for our Rubinius users until Rubygems supports
platform specific dependencies or Rubinius provides the standard library as
standard again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants