Use ContainExactly rather than MatchArray. #906

Merged
merged 2 commits into from Jan 4, 2014

Projects

None yet

3 participants

@thomasfedb
Contributor

As discussed in #905, due to change in rspec-expectations.

/cc @myronmarston

@thomasfedb
Contributor

Getting this failure on Travis:

Failures:
  1) route_to with should_not when assert_recognizes passes fails with custom message
     Failure/Error: expect do
       expected Exception with message matching /expected .* not to route to .*/, got #<RSpec::Expectations::ExpectationNotMetError: expected {:get=>"path"} not to route {:get=>"path"} to {"these"=>"options"}> with backtrace:
         # ./spec/rspec/rails/matchers/route_to_spec.rb:104:in `block (5 levels) in <top (required)>'
         # ./spec/rspec/rails/matchers/route_to_spec.rb:103:in `block (4 levels) in <top (required)>'
         # ./spec/rspec/rails/matchers/route_to_spec.rb:103:in `block (4 levels) in <top (required)>'

Failed examples:
rspec ./spec/rspec/rails/matchers/route_to_spec.rb:102 # route_to with should_not when assert_recognizes passes fails with custom message

Which doesn't seem related to my change.

@myronmarston
Member

The change looks OK to me. @alindeman -- how do you want to handle the fact that the build is broken with an unrelated change?

@alindeman
Contributor

I'll fix it separately and merge. I haven't yet nailed down why it's failing, but I assume another small change in -expectations.

@alindeman alindeman merged commit 5f2bdcb into rspec:master Jan 4, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details
@thomasfedb
Contributor

Cheers @alindeman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment