Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mocking Mutex.new #411

Merged
merged 1 commit into from Apr 26, 2020
Merged

Allow mocking Mutex.new #411

merged 1 commit into from Apr 26, 2020

Conversation

@JonRowe
Copy link
Member

JonRowe commented Apr 26, 2020

No description provided.

@JonRowe JonRowe force-pushed the allow-mutex-mocks branch from a27d344 to e902725 Apr 26, 2020
@pirj
pirj approved these changes Apr 26, 2020
Copy link
Member

pirj left a comment

Nice!
I hope new is the only method that users would stub :D

@JonRowe
Copy link
Member Author

JonRowe commented Apr 26, 2020

I hope new is the only method that users would stub :D

Its the only one that matters / breaks, stubbing on an individual instance of mutex would affect only those instances, and stubbing using any_instance is just going to be something we don't support (its not really reasonable to).

@JonRowe JonRowe merged commit f38f784 into master Apr 26, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JonRowe JonRowe deleted the allow-mutex-mocks branch Apr 26, 2020
JonRowe added a commit that referenced this pull request May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.