Try to use cStringIO whenever available. #1

Closed
wants to merge 5 commits into
from

Projects

None yet

2 participants

Contributor
didip commented Mar 8, 2012

A very small change. The performance enhancement really pays off for large number of asset files.

Also:

  • Added support for Python 2.6
  • Added feature: Delete old files when fingerprint mode is enabled.

One more thing:

Slimit (the javascript dependency), really messed up my distribute installation. Perhaps, it shouldn't need to require distribute?

Owner
rspivak commented Mar 8, 2012

Thanks a lot. I'll check your pull request in next couple days.
As for SlimIt 'distribute' dependency - too bad it messed up your installation. As a matter of fact it's no longer required and I'll just remove it. Thanks for reporting it.

Contributor
didip commented Mar 8, 2012

No problem. I'm glad I found this project.

I was rolling my own minifiers and happy that those code now lives in yaml config instead of application code.

@didip didip delete_old_files() had undefined behavior which leads to bug: When bu…
…ndle_type is not in ['css', 'javascript'], it may accidentally delete other compiled files.
28b236c
Owner
rspivak commented Mar 12, 2012

Hey Didip,

Your cString and Python 2.6 stuff is merged. Thanks a lot for the code.
I've also added you to AUTHORS and released a new version of crammit on pypi with your changes and a new 'files' feature.
I'll check your delete_old_files() code soon. Thanks again.

Contributor
didip commented Mar 12, 2012

Thanks for the quick response!

@didip didip closed this Mar 17, 2012
@acatton acatton added a commit to acatton/slimit that referenced this pull request Jan 26, 2015
@rspivak @acatton rspivak + acatton Remove unnecessary 'distribute' dependency.
Thanks to Didip Kerabat for noticing it:
rspivak/crammit#1
f764905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment