Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Problem with for loop with ? operator in initializer position #25

Closed
davidkhess opened this Issue · 4 comments

2 participants

David K. Hess Ruslan Spivak
David K. Hess

The following javascript is not minimized correctly:

>>> minify("for(a?b:c;d;)e=1;")
'for(a?b:cd;)e=1;'
>>> 

It doesn't properly emit a needed semicolon.

Ruslan Spivak
Owner

Thanks for reporting it, David. I'll look into it.

Ruslan Spivak
Owner

Fixed in efaafdb

Ruslan Spivak rspivak closed this
David K. Hess

Thanks! I made it past this one and opened up an issue for the next one I hit.

I'm finding these odd cases in the Knockout JS code. I'm concatenating their minified stuff with some unminified things and then running slimit over the result.

Ruslan Spivak
Owner

Thanks David, it's good to know about those odd cases.

Antoine Catton acatton referenced this issue from a commit in acatton/slimit
Ruslan Spivak Fix bug: rspivak#25
Problem with for loop with ? operator in initializer position
6a3bf72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.