New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with for loop with ? operator in initializer position #25

Closed
davidkhess opened this Issue Mar 13, 2012 · 4 comments

Comments

Projects
None yet
2 participants
@davidkhess

davidkhess commented Mar 13, 2012

The following javascript is not minimized correctly:

>>> minify("for(a?b:c;d;)e=1;")
'for(a?b:cd;)e=1;'
>>> 

It doesn't properly emit a needed semicolon.

@rspivak

This comment has been minimized.

Show comment
Hide comment
@rspivak

rspivak Mar 14, 2012

Owner

Thanks for reporting it, David. I'll look into it.

Owner

rspivak commented Mar 14, 2012

Thanks for reporting it, David. I'll look into it.

@rspivak

This comment has been minimized.

Show comment
Hide comment
@rspivak

rspivak Mar 14, 2012

Owner

Fixed in efaafdb

Owner

rspivak commented Mar 14, 2012

Fixed in efaafdb

@rspivak rspivak closed this Mar 14, 2012

@davidkhess

This comment has been minimized.

Show comment
Hide comment
@davidkhess

davidkhess Mar 14, 2012

Thanks! I made it past this one and opened up an issue for the next one I hit.

I'm finding these odd cases in the Knockout JS code. I'm concatenating their minified stuff with some unminified things and then running slimit over the result.

davidkhess commented Mar 14, 2012

Thanks! I made it past this one and opened up an issue for the next one I hit.

I'm finding these odd cases in the Knockout JS code. I'm concatenating their minified stuff with some unminified things and then running slimit over the result.

@rspivak

This comment has been minimized.

Show comment
Hide comment
@rspivak

rspivak Mar 14, 2012

Owner

Thanks David, it's good to know about those odd cases.

Owner

rspivak commented Mar 14, 2012

Thanks David, it's good to know about those odd cases.

acatton added a commit to acatton/fork--rspivak--slimit that referenced this issue Jan 26, 2015

Fix bug: rspivak#25
Problem with for loop with ? operator in initializer position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment