Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Compressed files crash in IE8 because of .class #34

Closed
edmellum opened this Issue · 5 comments

3 participants

@edmellum

Compressed files use .class which freaks IE8 out and makes it crash. To replicate just compress jQuery 1.7.2 and try to run it in IE8.

@rspivak rspivak was assigned
@rspivak
Owner

Thanks for the bug report. I'll take a look at it.

@rspivak
Owner

The problem happened to be that 'class' wasn't part of the currently reserved keywords and the minifier transformed bracket accessor obj["class"] to obj.class which messed up IE8. I fixed the issue by moving 'class' from future reserved keywords to the current ones and released new version 0.7.4 of Slimit to PyPI.

This is the commit: 887e3bb

Let me know if you have any other problems with IE8 and thanks again for filing the bug.

@edmellum

Just tested my big ball 'o JS in IE8 and IE7 and both run the code perfectly. Thanks for the super-quick fix!

@edmellum edmellum closed this
@rspivak
Owner

Perfect! Thanks.

@Prakashandrews

Hi,

I am using Jquery1.7 because to support Bootstrap code and I am getting "H.attachEvent" is not function error. Any one can help me out from this. Its changing the compatibility view while the page is loading(IE-8 to IE7).

@acatton acatton referenced this issue from a commit in acatton/slimit
@rspivak Bug fix: rspivak#34 7e40fe0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.