[codex] speed up non-PnP resolve#223
Draft
hardfist wants to merge 1 commit into
Draft
Conversation
Merging this PR will improve performance by 7.71%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokio::fsblocking handoff on current-thread runtimes while keeping multithreaded behavior unchangedWhy
The single-thread resolver benchmark was spending a measurable amount of time in path-cache hashing and Tokio fs handoff overhead. These changes keep PnP-enabled behavior on the existing path while optimizing the non-PnP hot path used by the benchmark.
Impact
Validation
cargo clippy --all-features -- -D warningscargo fmt --checkcargo teststill has the same 6 pre-existing PnP failures observed onorigin/mainresolver[single-thread]54.77 ms,resolver[[single-threaded]resolve with many extensions]132.01 msresolver[single-thread]39.85 ms (-27.24%),resolver[[single-threaded]resolve with many extensions]124.84 ms (-5.43%)Artifacts
optimization-artifacts/codspeed/20260518-223013-baseline2/run.logoptimization-artifacts/codspeed/20260518-223853-exact-cache-plus-direct-fs/run.log