feat: add blog authors wrapper#94
Merged
Merged
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add blog authors wrapper (and add @rspress/core as peerDeps & devDeps)
Lynx's website achieves this visual order:
back button -> h1 -> date -> author list -> copy button
Except h1, other things are render in
<BlogHeader/>. The .mdx places after h1. The back button is rendered inside BlogHeader, but CSS uses position: absolute to visually move it above the h1. It also hides the default .rp-llms-container then re-renders the same LlmsContainer / LlmsCopyButton / LlmsViewOptions inside BlogHeader, after the author list.It's a so hacky way to achieve thire effect. i don't think we should learn from them. we could just create a authors wrapper firstly.
If needed, we could consider more flexible composition capabilities and hooks into Rspress maybe.