Stop to working with eruby #69

Closed
rafamoreira opened this Issue Aug 26, 2013 · 6 comments

Comments

Projects
None yet
5 participants

With this commit: 2642aad Sparkup has stopped to work with .html.erb files, the error message is:

Options error: option --eruby not recognized
Try --help for a list of arguments.

I could not find the exactly source of the problem, but before this commit, everything was working fine.

Owner

rstacruz commented Aug 27, 2013

Strange—I don't believe explicit eruby was ever implemented. Are you sure you weren't using a fork or a patch?

I'm totally sure, I only noticed that because I pushed my vimfiles to a new machine and installed the new version with Vundle.

Also, in my fork https://github.com/rafamoreira/sparkup I just reverted the commits to 53dd569 and everything is fine again with erb files.

But i verified the code, and now, the call from sparkup on vim, is passing an arg -- filetype at https://github.com/rstacruz/sparkup/blob/2642aadf89b1e340cbc698ffe1a52dfc284ddc4f/vim/ftplugin/html/sparkup.vim#L42 to check if a file is xml or html.

The problem is, eruby filetype isn't an valid option on cmdline_keys list at https://github.com/rstacruz/sparkup/blob/2642aadf89b1e340cbc698ffe1a52dfc284ddc4f/vim/ftplugin/html/sparkup.py#L1078

I tried to add an option in cmdline_keys for eruby filetype ('', 'eruby', 'html default'),, and now the error is gone, everything is working.

Finally, I don't know what is the best option to fix this. If tell explicit in the options, all the filetypes which is supported as html, or some kind of dynamic option which captures xml to XmlDialect and everything else to HtmlDialect.

Owner

rstacruz commented Aug 27, 2013

Seems ' --' . &filetype is a pretty naïve solution... any alternative proposals are welcome.

atn34 commented Aug 30, 2013

How about ' --filetype=' . &filetype or something like that. Then if the filetype is not recognized default to html.

+1 on this PR. This also seems to affect HTML files w/ filetype htmldjango, from using the plugin django.vim.

Contributor

blueyed commented Oct 7, 2013

Closed by #71.

I will open a new issue / pull request with my concerns about it.

faceleg closed this in b4bc30b Oct 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment