Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Revert "replace --<filetype> with --filetype=<filetype>" and other issues caused by huge pull request #83

Open
blueyed opened this Issue Oct 7, 2013 · 0 comments

Comments

Projects
None yet
1 participant
Contributor

blueyed commented Oct 7, 2013

  1. Sparkup itself only needs to know if it should use the XML or HTML dialect. Therefore the --xml and --html options make totally sense.
    The Vim invocation of sparkup needs to be fixed (issue #69).
  2. Also, sparkup.py does not appear to be compatible with Python3, and therefore the shebang (/usr/bin/env python2) should be kept for Linux/Unix systems (just recently introduced in 04cfd22).
    I will therefore rename sparkup.py to sparkup again, and change the symlinks.
    (You have to think about sparkup being used standalone here!)

I am quite sure to have left a comment with issue #69 or its pull request a few days ago, stating that I would fix the filetype issue (but cannot find it anymore).

I will provide a pull request in an hour or so.

blueyed added a commit to blueyed/sparkup that referenced this issue Oct 7, 2013

Remove `--filetype` option; Vim: pass `--xml` properly
vim/ftplugin/html/sparkup.vim:
 - pass `--xml`, if 'xml' is used in &filetype (might be several)
 - build args to sparkup on every call: its input is dynamic,
   especially the new &expandtab
 - use "python" workaround only for Windows (it is executable for
   Linux/Unix), and its shebang should be used

Fixes #69, #83.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment