Fix XML processing #82

merged 1 commit into from Oct 6, 2013


None yet

2 participants

ghost commented Oct 2, 2013

I accidentally removed the empty XML dialect in my previous pull requests... so here it is.

Duncan de Wet Fix XML processing da73973
faceleg commented Oct 2, 2013

Will this be the last one?

ghost commented Oct 3, 2013

Yes, I hope so. Sorry.

ghost commented Oct 3, 2013

But also do remember, as I stated clearly in my original pull request #80, I have not tested it in Textmate as I don't have a Mac.

ghost commented Oct 6, 2013

@faceleg Do you plan to merge this or not? It does fix the XML filetype and I have been using my own fork for a while and don't think there are any more problems so it should be the last one.

I do apologise for sending 3 pull requests but after all I did help your project.

@faceleg faceleg merged commit 615f1c8 into rstacruz:master Oct 6, 2013
faceleg commented Oct 6, 2013

Thanks! I've been sick since my last message, didn't open my laptop until today.

blueyed commented Oct 7, 2013

@duncannz thanks for helping the project, but it appears to be quite a mess. See issue #83.
For one, it would help a lot to have more atomic commits (addressing single issues), and to not change contents of files, when renaming/moving them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment