fix testcases #90

Merged
merged 3 commits into from Jan 15, 2014

Conversation

Projects
None yet
2 participants
Contributor

nixon commented Dec 20, 2013

Two testcases were failing due to code changes that modified the output.

  • Commit 170f752 changed the output to an html5 self-closing tag style
  • Commit f594060 removed the button synonym

This pull request updates the expected testcases to reflect these changes.

nixon added some commits Dec 20, 2013

@nixon nixon return number of testcase failures
allow `git bisect` to know whether or not all tests passed.
7010319
@nixon nixon test for html5 self-closing tags
Commit 170f752 changed the output to an html self-closing tag style
causing the Short testcase to fail:

```
 - Shortcut test                  [FAIL]
= input:button
Actual output (condensed):
 | '<input type="button" class="button" value="$1" name="$2">$0'
Actual output:
 | <input type="button" class="button" value="$1" name="$2">$0
Expected:
 | <input type="button" class="button" value="$1" name="$2" />$0
```

Update the testcase so that it matches the new output.
262c9bf
@nixon nixon fix button testcase
Commit f594060 removed the button synonym which caused the Shortcut
synonym testcase to fail:

```
 - Shortcut synonym test          [FAIL]
= button
Actual output (condensed):
 | '<button>$1</button>$0'
Actual output:
 | <button>$1</button>$0
Expected:
 | <input type="button" class="button" value="$1" name="$2" />$0
```

Update test case so that it matches actual desired button output.
9bc9b3d

@faceleg faceleg added a commit that referenced this pull request Jan 15, 2014

@faceleg faceleg Merge pull request #90 from nixon/fix_tests
fix testcases
4cd3787

@faceleg faceleg merged commit 4cd3787 into rstacruz:master Jan 15, 2014

nixon deleted the nixon:fix_tests branch Jan 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment