-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column filter css affected when switching to tab/page with shiny slider #49
Comments
Can you provide two screenshots that show how the styles change from one case to the other? I could see some subtle padding differences, and that does not seem to be too bad in my eyes. Perhaps you meant something more significant that I failed to see. |
Okay, that is worse than I imagined, but given that you can get rid of the clear buttons now, I guess this is no longer an urgent issue. |
Just an FYI ... without the clear button the text from different cells can overlap. See screenshot. Like I said, not a big deal but enough for me to prefer Update: Just to be clear ... the overlap only occurs after visiting a page with a shiny slider in it. |
Ugh... 😵 |
In style.css I have:
table.dataTable tfoot td, table.dataTable thead td {
padding-top: 0px;
padding-bottom: 0px;
padding-left: 0px;
padding-right: 0px;
}
In Data > View this looks fine. Go to Base > Single mean (which has a filter) and then back to Data > View and you will see the css has been changed. This happens for any page with a slider (e.g, all tools in Base except Cross-tabs, Regression (OLS and GLM, but not Correlation which doesn't have a slider). To test this some more I added a slider to the Data > Visualize tab and the same effect occurred. Switching back and forth changes the CSS.
Note that this effect also occurs when I comment out the CSS listed above. In that case the default CSS for the column headers/footers is still changed when switching back and forth to pages with shiny sliders.
See for link below for example:
https://vnijs.shinyapps.io/quant
All package versions used are at: https://github.com/vnijs/radiant_miniCRAN
The text was updated successfully, but these errors were encountered: