Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to plotly's persistent selection mode #498

Merged
merged 2 commits into from Feb 9, 2018

Conversation

Projects
None yet
2 participants
@cpsievert
Copy link
Contributor

cpsievert commented Feb 9, 2018

This adds the ability to perform persistent selection with plotly (similar to how rstudio/leaflet#346 does for leaflet).

It would be ideal to have rows somehow reflect plotly's selection color, let me know if have any ideas how best to go about that (e.g. color the text or highlight the row?)

dt

cpsievert and others added some commits Feb 9, 2018

@yihui

yihui approved these changes Feb 9, 2018

Copy link
Member

yihui left a comment

Looks great! I don't have a thought about the color.

@yihui yihui added this to the v0.4 milestone Feb 9, 2018

@yihui yihui merged commit 5fbebfe into rstudio:master Feb 9, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@cpsievert

This comment has been minimized.

Copy link
Contributor Author

cpsievert commented Feb 9, 2018

Cool, thanks! BTW, adding color can be useful for making comparisons, so I would say we should add it at some point, but I might not have the time for it in the near future, want me to raise an issue?

dt2

@yihui

This comment has been minimized.

Copy link
Member

yihui commented Feb 9, 2018

I think it is a very cool idea, although I definitely don't have time, either :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.