Skip to content

Upgrade dataTables library to 1.10.20#756

Merged
yihui merged 14 commits intomasterfrom
upgrade-js-library
Feb 3, 2020
Merged

Upgrade dataTables library to 1.10.20#756
yihui merged 14 commits intomasterfrom
upgrade-js-library

Conversation

@shrektan
Copy link
Collaborator

@shrektan shrektan commented Jan 23, 2020

Closes #763

  • improve update_DT.R
  • remove all the deprecated files (the theme files other than bootstrap should not be used as well but we may need them in the future when we want to support more themes)
  • update js/css source files
  • bumper DataTablesVersion
  • add the new extension searchpanes
  • make sure searchpanel ext works by creating an example (note it only works for the client-processing mode as mentioned in https://datatables.net/blog/2020-01-13 )
  • make sure all the example can be run well
  • rebuild the site (see Rebuild site (and update Extension and Plugins) #757)
  • update NEWs and bumper DT version

SearchPanes Example

DT::datatable(
  iris,
  options = list(dom = 'Pfrtip', columnDefs = list(list(
    searchPanes = list(show = FALSE), targets = 1:3
  ))),
  extensions = c('Select', 'SearchPanes')
)

image

@shrektan shrektan added this to the v0.12 milestone Jan 23, 2020
@shrektan shrektan marked this pull request as ready for review January 24, 2020 09:30
@shrektan shrektan requested a review from yihui January 24, 2020 09:30
Copy link
Contributor

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@yihui yihui merged commit 41f8a16 into master Feb 3, 2020
@yihui yihui deleted the upgrade-js-library branch February 3, 2020 22:12
@saheedb
Copy link

saheedb commented Apr 11, 2020

Why does targets = 1:3 specify columns 2 and 5 in iris? I'm unable to get searchPanes to just show the columns I'm interested in--I'm not sure how the targets parameter is supposed to work.

@shrektan
Copy link
Collaborator Author

Why does targets = 1:3 specify columns 2 and 5 in iris? I'm unable to get searchPanes to just show the columns I'm interested in--I'm not sure how the targets parameter is supposed to work.

  1. It's not column 2 and 5. The columns in the searchPane are 4th and 5th.
  2. searchPanes = list(show = FALSE), targets = 1:3 means "do not show 1:3 in the searchPanes" (it's show = FALSE not TRUE). By default, the searchPanes will display all the columns so you are supposed to specify the "hidden" columns.
  3. For more info please look at the offical example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unclickable collection button in modals

3 participants