Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dataTables library to 1.10.20 #756

Merged
merged 14 commits into from Feb 3, 2020
Merged

Upgrade dataTables library to 1.10.20 #756

merged 14 commits into from Feb 3, 2020

Conversation

shrektan
Copy link
Collaborator

@shrektan shrektan commented Jan 23, 2020

Closes #763

  • improve update_DT.R
  • remove all the deprecated files (the theme files other than bootstrap should not be used as well but we may need them in the future when we want to support more themes)
  • update js/css source files
  • bumper DataTablesVersion
  • add the new extension searchpanes
  • make sure searchpanel ext works by creating an example (note it only works for the client-processing mode as mentioned in https://datatables.net/blog/2020-01-13 )
  • make sure all the example can be run well
  • rebuild the site (see #757)
  • update NEWs and bumper DT version

SearchPanes Example

DT::datatable(
  iris,
  options = list(dom = 'Pfrtip', columnDefs = list(list(
    searchPanes = list(show = FALSE), targets = 1:3
  ))),
  extensions = c('Select', 'SearchPanes')
)

image

@shrektan shrektan added this to the v0.12 milestone Jan 23, 2020
@shrektan shrektan marked this pull request as ready for review Jan 24, 2020
@shrektan shrektan requested a review from yihui Jan 24, 2020
yihui
yihui approved these changes Feb 3, 2020
Copy link
Member

@yihui yihui left a comment

Thank you very much!

@yihui yihui merged commit 41f8a16 into master Feb 3, 2020
2 checks passed
@yihui yihui deleted the upgrade-js-library branch Feb 3, 2020
@saheedb
Copy link

@saheedb saheedb commented Apr 11, 2020

Why does targets = 1:3 specify columns 2 and 5 in iris? I'm unable to get searchPanes to just show the columns I'm interested in--I'm not sure how the targets parameter is supposed to work.

@shrektan
Copy link
Collaborator Author

@shrektan shrektan commented Apr 11, 2020

Why does targets = 1:3 specify columns 2 and 5 in iris? I'm unable to get searchPanes to just show the columns I'm interested in--I'm not sure how the targets parameter is supposed to work.

  1. It's not column 2 and 5. The columns in the searchPane are 4th and 5th.
  2. searchPanes = list(show = FALSE), targets = 1:3 means "do not show 1:3 in the searchPanes" (it's show = FALSE not TRUE). By default, the searchPanes will display all the columns so you are supposed to specify the "hidden" columns.
  3. For more info please look at the offical example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants