Support custom flags for the hugo command via hugo_build() #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
requested changes
May 10, 2019
R/hugo.R
Outdated
| hugo_cmd(c( | ||
| if (local) c('-b', site_base_dir(), '-D', '-F'), | ||
| if (isTRUE(do_minify)) c('--minify'), |
There was a problem hiding this comment.
Let's just do this:
Suggested change
| if (isTRUE(do_minify)) c('--minify'), | |
| getOption('blogdown.hugo.args'), |
since it is more general-purpose and allows you to set arbitrary hugo options, not limited to --minify.
This new option should be documented at https://bookdown.org/yihui/blogdown/more-global-options.html
There was a problem hiding this comment.
Thanks, done in jozefhajnala@db3c0da
|
Please also remember to add an item to |
Done (in a separate commit), please feel free to comment on conventions/wording, happy to align. |
yihui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Hugo v0.47 there is minification support for the final rendered output. This PR proposes an option to use
--minifywhen building sites with blogdown.