propose changes to the New Post addin#432
Merged
yihui merged 15 commits intorstudio:masterfrom Mar 4, 2020
maelle:newpostaddintweaks
Merged
propose changes to the New Post addin#432yihui merged 15 commits intorstudio:masterfrom maelle:newpostaddintweaks
yihui merged 15 commits intorstudio:masterfrom
maelle:newpostaddintweaks
Conversation
Member
|
@maelle The drop-down for blog directories has been something I've wanted for a while, so I'm very glad to see this PR! |
gadenbuie
reviewed
Mar 2, 2020
Co-Authored-By: Garrick Aden-Buie <gadenbuie@mail.usf.edu>
Contributor
Author
|
@gadenbuie what do you think of this new version? I updated my first comment. Thanks for your feedback! |
yihui
approved these changes
Mar 3, 2020
Collaborator
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
I love these ideas! Thank you!
Would you mind posting a screenshot? I just want to double check if the width of the select input is good.
BTW, I'll make some cosmetic changes before I merge this PR, and you don't need to worry about my style preferences.
R/utils.R
Outdated
|
|
||
| option2 <- list.dirs(file.path(site_root(), "content"), | ||
| full.names = FALSE, | ||
| recursive = FALSE) |
Collaborator
There was a problem hiding this comment.
I guess it makes sense to exclude _files and _cache folders.
Contributor
Author
|
Glad you liked the ideas @yihui! Now it's mostly @gadenbuie's code 😁
|
yihui
added a commit
that referenced
this pull request
Mar 4, 2020
yihui
added a commit
that referenced
this pull request
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm proposing two changes to the very cool New Post addin:
If there's no
blogdown.authoroption andwhoamiis installed, try to guess the author name usingwhoami.The possible subdirectories are the combination of the option
blogdown.subdirif it exists, '' and existing subdirectories; the selected value is either `blogdown.subdir or the first option; it is possible to create a subdirectory from the addin. (edited after getting feedback from @gadenbuie)These suggestions might reduce the setup efforts needed to use the addin.
Opening a PR instead of an issue is a bit bold, and I don't assume my PR will be merged, but it was easier to communicate my ideas by implementing them. 🙂