Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also detect Pandoc's inline raw attributes to determine if Pandoc should be run #585

Merged
merged 2 commits into from Feb 5, 2021

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Feb 5, 2021

This comes from https://community.rstudio.com/t/changes-to-blogdown-shortcode-open-type-html-and-blogdown-shortcode-close-type-html/93727/4 (thanks @datalorax)

This PR change the regex to also detect inline raw content and not just block raw content.

The issue arises with blogdown::shortcode_open() because it will use htmltools and the new Pandoc's raw attributes to escape inline content - still because rmarkdown set the option to do so by default.

This simplify the regex instead of adding a new one. Does it sound good ?

This fixes the issue reported in community.

Also:

  • Did not added anything to NEWS because there is still a bullet for blogdown.markdown.format
  • Added some tests because why not.

@cderv cderv requested a review from yihui Feb 5, 2021
@cderv cderv changed the title also detect content{=format} to determine if Pandoc should be run also detect Pandoc's inline raw attributes to determine if Pandoc should be run Feb 5, 2021
yihui
yihui approved these changes Feb 5, 2021
Copy link
Member

@yihui yihui left a comment

Sounds good. Thanks!

tests/testit/test-render.R Show resolved Hide resolved
@yihui yihui merged commit 1f79c7b into master Feb 5, 2021
5 checks passed
@yihui yihui deleted the inline-raw branch Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants