Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default HTML output on iPad #60

Open
kylelundstedt opened this issue Mar 23, 2016 · 16 comments
Labels
bug

Comments

@kylelundstedt
Copy link

@kylelundstedt kylelundstedt commented Mar 23, 2016

Hi @yihui
When browsing the standard HTML output from bookdown on an iPad, there doesn't seem to be a way to collapse the sidebar containing the table of contents. So, when reading the bookdown or r4ds websites, the sidebar always takes up over 1/3 of the reading space on the iPad. It would be great if the default HTML output allowed one to collapse/expand the TOC, or to see TOC in a menu.

Thanks
Kyle

@yihui

This comment has been minimized.

Copy link
Member

@yihui yihui commented Mar 23, 2016

You can tap the first button on the toolbar to toggle the sidebar:

screen shot 2016-03-23 at 5 03 30 pm

@kylelundstedt

This comment has been minimized.

Copy link
Author

@kylelundstedt kylelundstedt commented Mar 23, 2016

Hmm. I'm probably a complete knucklehead, but the toolbar does not appear in Safari on the iPad when viewing the HTML output. I went to both of the following sites to confirm:

http://rstudio.github.io/bookdown/
http://r4ds.had.co.nz

No amount of tapping, double-tapping, etc causes the toolbar to appear. What am I missing?

@yihui

This comment has been minimized.

Copy link
Member

@yihui yihui commented Mar 24, 2016

Okay, I just looked at it on iPad and indeed the toolbar buttons were invisible. This is similar to #44. The buttons are actually there but I don't know why they are not displayed. You can scroll down the page, and you can see a blank toolbar at the top. You can actually tap at the left of the toolbar.

@yihui yihui added the bug label Mar 24, 2016
@jjallaire

This comment has been minimized.

Copy link
Member

@jjallaire jjallaire commented Apr 6, 2016

@jmcphers If you could spend 15 minutes looking at this we'd be eternally grateful (realize you have plenty of other things cooking this week so please just spend 15 minutes in hopes this is a really simple thing to resolve). The issue does repro on the XCode iPad simulator but I couldn't figure out how to do the equivalent of Inspect Element there.

@yihui yihui modified the milestone: v0.2 Jul 12, 2016
@yihui yihui modified the milestone: v0.2 Nov 16, 2016
dataopt added a commit to dataopt/bookdown that referenced this issue Apr 11, 2018
This fixes the toolbar not appearing on iPad.
@dataopt dataopt referenced this issue Apr 11, 2018
@dataopt

This comment has been minimized.

Copy link
Contributor

@dataopt dataopt commented Apr 11, 2018

It looks like the book-header.fixed class is causing problems on the iPad. It is not clear why that is the case. So there is a way to bring back the toolbar by simply removing this class entirely from the css definitions. But doing so will make the toolbar scroll with the body content. HOWEVER, this latter behaviour is what is found in the current gitbooks. See this for example.

dataopt added a commit to dataopt/bookdown that referenced this issue Apr 11, 2018
dataopt added a commit to dataopt/bookdown that referenced this issue Apr 12, 2018
The template has incorrect nesting of the div for book-header.
@luispuerto

This comment has been minimized.

Copy link

@luispuerto luispuerto commented Aug 22, 2019

Hey!!

Is this going to be fixed?

There is a workaround that is to pull with your finger in the top part of the screen so buttons of the menu will show up for a second —so you know where you need to push— but a solution would be really appreciated. :)

@dullhunk

This comment has been minimized.

Copy link

@dullhunk dullhunk commented Sep 8, 2019

As far as I can see, as of September 2019, this is still a bug. I've tested by viewing e.g. r4ds.had.co.nz on a reasonably up to date iPad Pro and the menu icon (and whole menu bar) does not appear. @yihui

Not a problem on safari and macbook, but haven't tried an iPhone which will probably have the same problem and an ipad. @luispuerto

If you tap on the blank space where the menu items should be, the menus work, but that's not much use unless you're familiar with bookdown.

@luispuerto

This comment has been minimized.

Copy link

@luispuerto luispuerto commented Sep 9, 2019

I've tried in the iPhone and the problem is the same. It a problem with Safari from iOS I guess. But it also happens on Firefox for iOS at least in the iPad, so I guess it's a iOS problem in general. I believe that all of them use webkit.

@dullhunk

This comment has been minimized.

Copy link

@dullhunk dullhunk commented Sep 10, 2019

If it is is webkit that's the problem, it doesn't affect webkit & safari on a laptop / desktop - they work fine.

It seems to be specific issue with webkit/safari on an iPad/iPhone @luispuerto

@chipbrock

This comment has been minimized.

Copy link

@chipbrock chipbrock commented Oct 25, 2019

This is a real problem if one is trying to show off work. Please fix it! Thanks.

@luispuerto

This comment has been minimized.

Copy link

@luispuerto luispuerto commented Oct 26, 2019

@chipbrock this is only still a problem if you haven't update to the last version of iPadOS or iOS.

@chipbrock

This comment has been minimized.

Copy link

@chipbrock chipbrock commented Oct 26, 2019

Thanks for a quick reply.

I’m running iPadOS 13.1.3 on a new iPad mini and it is not functioning as it should - no sandwich icon (or any icon) at the top of an otherwise respectable page of a document.

On a computer, the icons are all proudly displayed as per normal.

So I don’t think the new update fixes this. What am I missing? See attachments.

screenshot_1114

screenshot_1113

@luispuerto

This comment has been minimized.

Copy link

@luispuerto luispuerto commented Oct 26, 2019

Can you check this one?

https://geocompr.robinlovelace.net/

In my iPad works just fine

IMG_0103

@luispuerto

This comment has been minimized.

Copy link

@luispuerto luispuerto commented Oct 26, 2019

It's working also fine on my iPhone 5S with iOS12

IMG_EAF3F57EF28E-1

@chipbrock

This comment has been minimized.

Copy link

@chipbrock chipbrock commented Oct 26, 2019

Thanks.

I think I get it now. Your page does not render with the sandwich visible on my ipad mini, but it does on my phone and on my ipad pro. So I suspect there's an issue with the adaptive width assignments in the css that governs the framework.

BTW. My page also renders fine in my larger ipad confirming for me that this is the problem. There must be an in-between size under which the sidebar collapses - which it does on the phone that's not in sync with the instructions to the header.

What I REALLY wish could be instituted is a switch to collapse the sidebar by default. From browsing other discussions, this seems to be a feature and not a ...lack of implementation.

In any case, this sandwich showing/not showing does seem to be a bug in css.

@dullhunk

This comment has been minimized.

Copy link

@dullhunk dullhunk commented Oct 29, 2019

This is a bug on iPad pro too. For example here's a screenshot from an iPad Pro (12.9 inch) 2nd generation running software version 13.1.3 looking at https://r4ds.had.co.nz/ by @garrettgman and @hadley. The "hamburger" menu item does not appear @yihui @chipbrock @luispuerto
File 29-10-2019, 09 56 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.