fix: Chrome no longer supports old headless mode#189
Merged
Conversation
cderv
approved these changes
Jan 16, 2025
Contributor
cderv
left a comment
cderv
left a comment
There was a problem hiding this comment.
Looks good. Do you know if new headless works well with chromote already ?
Member
Author
In theory, it should! IIRC |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #187
We now default to
--headlessand pass whatever value is given inchromote.headlessorCHROMOTE_HEADLESSalong directly to Chrome, relying on Chrome to fail for invalid headless values (if it fails at all).