Skip to content

feat: Set a user-specific crash dump directory - #194

Merged
gadenbuie merged 3 commits into
mainfrom
fix/134-chromote-crash-log-paths
Jan 21, 2025
Merged

feat: Set a user-specific crash dump directory#194
gadenbuie merged 3 commits into
mainfrom
fix/134-chromote-crash-log-paths

Conversation

@gadenbuie

@gadenbuie gadenbuie commented Jan 21, 2025

Copy link
Copy Markdown
Member

Fixes #134

Sets --crash-dumps-dir for each session and uses tempfile() to create a consistent path name for a given session. (Previously, stdout and stderr would be written to log files with different "hashes".)

options(chromote.launch.echo_cmd = TRUE)
b <- ChromoteSession$new()
#> Running '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome' \
#>   --headless '--remote-debugging-port=23311' \
#>   '--remote-allow-origins=http://127.0.0.1:23311' \
#>   '--crash-dumps-dir=/var/folders/yl/0xhq7c7n3z7_9hp1356kctbr0000gp/T//RtmpcsWZVF/chrome-bd71710535fb-crashpad' \
#>   '--force-color-profile=srgb' --disable-extensions --mute-audio

With this change, we now use the same tempdir prefix for all three session-specific files/directories:

  • {tempdir}/chrome-bd71710535fb-crashpad/ for crash dumps
  • {tempdir}/chrome-bd71710535fb-stdout.log
  • {tempdir}/chrome-bd71710535fb-stderr.log

@gadenbuie
gadenbuie marked this pull request as ready for review January 21, 2025 15:45
@gadenbuie
gadenbuie requested a review from schloerke January 21, 2025 15:46
Comment thread R/chrome.R Outdated
@gadenbuie
gadenbuie merged commit 26ecb2b into main Jan 21, 2025
@gadenbuie
gadenbuie deleted the fix/134-chromote-crash-log-paths branch January 21, 2025 16:03
@github-actions
github-actions Bot restored the fix/134-chromote-crash-log-paths branch January 21, 2025 16:07
@gadenbuie
gadenbuie deleted the fix/134-chromote-crash-log-paths branch January 22, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chromote should set a user-specific crash dump directory

2 participants