Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkable valueBox "remembers" previous links #139

Closed
jarodmeng opened this issue Aug 27, 2017 · 1 comment
Closed

Linkable valueBox "remembers" previous links #139

jarodmeng opened this issue Aug 27, 2017 · 1 comment

Comments

@jarodmeng
Copy link

@jarodmeng jarodmeng commented Aug 27, 2017

I use valueBox to dynamically create links based on user input. When the dashboard first launches, everything works as expected. Clicking on the value box opens the link. However, when I change the input and click on the value box again, it opens two tabs, one for the old link and one for the new link. If I change the input again, clicking the value box would open three tabs. It appears that somehow the value box "remembers" all previous links and open all of them when clicked.

Here is a minimum example. I comment out the code so that GitHub doesn't try to render the markdown.

# ---
# title: "Test Linkable valueBox"
# output: 
#   flexdashboard::flex_dashboard:
#     orientation: rows
# runtime: shiny
# ---
# 
# ```{r setup, include=FALSE}
# library(flexdashboard)
# ```
# 
# Sidebar {.sidebar}
# =======================================================================
# 
# ```{r}
# textInput("website", "Website", "http://google.com")
# ```
# 
# Dashboard
# =======================================================================
# 
# Row
# -----------------------------------------------------------------------
# 
# ### valueBox {.value-box}
# 
# ```{r}
# renderValueBox({
#   valueBox(value = input$website, href = input$website)
# })
# ```
@jjallaire jjallaire closed this in 73a7fe1 Aug 28, 2017
@jjallaire
Copy link
Member

@jjallaire jjallaire commented Aug 28, 2017

Thanks for the report, should now be fixed on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.