Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the html4 output format instead of the default html5 in Pandoc 2.0 #150

Merged
merged 1 commit into from Nov 9, 2017

Conversation

@yihui
Copy link
Member

@yihui yihui commented Nov 9, 2017

Fixes #149.

Basically Pandoc 2.0 starts to default to html5 when the output format is the ambiguous html (previously it was html4), and the consequence is that the section divs actually use the <section> tag instead of <div>. See https://groups.google.com/forum/#!topic/pandoc-discuss/d-d07z2iHJs for more information.

I have compared the output with this PR + Pandoc 2.0 against Pandoc 1.19, and the output files seem to be identical.

@yihui yihui mentioned this pull request Nov 9, 2017
@jjallaire
Copy link
Member

@jjallaire jjallaire commented Nov 9, 2017

That's excellent! Thanks for sorting that out :-)

@bborgesr Let's plan on a CRAN release for flexdashboard as well. We should also take a look at learnr to see if we need the same fix there and then also submit that to CRAN.

@jjallaire jjallaire merged commit dd4440a into rstudio:master Nov 9, 2017
@yihui yihui deleted the yihui:bugfix/pandoc2.0 branch Nov 9, 2017
@bborgesr
Copy link
Contributor

@bborgesr bborgesr commented Nov 10, 2017

@jjallaire: in learnr, I think there's just one instance with this problem: https://github.com/rstudio/learnr/blob/master/R/tutorial-format.R#L101-L103

It's simple enough to change it there, but at least the two demo tutorials ran fine for me with the newer version of pandoc and no changes. I'm not familiar enough with the package to know if that's representative. I'd err on the side of caution and substitute those lines in learnr a la this PR. Even if we're not preventing any bugs, at least, learnr would be internally consistent with all of these other rmarkdown/pandoc packages.

I can go ahead with that if you agree.

As far as the releases go, is there a release checklist that I can go through? I can improvise if not; I just wanted to make sure I don't have any blind spots.

@jjallaire
Copy link
Member

@jjallaire jjallaire commented Nov 10, 2017

Yes, let's change it there just to be on the safe side.

No release checklist. My guess is that there are very very few changes from the last release so just doing a global diff and then scenario and/or unit testing as appropriate around the diff will be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.