Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using dplyr::bind_rows() instead of dplyr::rbind_all() #482

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@romainfrancois
Copy link
Contributor

@romainfrancois romainfrancois commented Oct 7, 2019

We're tidyverse/dplyr#4579 in the process of releasing dplyr 0.8.4 and this package fail at our reverse dependency checks because the dplyr::rbind_all() function has been formally removed after being deprecated for many versions.

We might revert that decision because it affects a handful of packages, but in any case even if rbind_all() stays a little longer, you still should use bind_rows() instead.

# ggvis

<details>

* Version: 0.4.4
* Source code: https://github.com/cran/ggvis
* URL: http://ggvis.rstudio.com/
* Date/Publication: 2018-09-28 21:50:03 UTC
* Number of recursive dependencies: 53

Run `revdep_details(,"ggvis")` for more info

</details>

## Newly broken

*   checking dependencies in R code ... NOTE
    ```
    Missing or unexported object: ‘dplyr::rbind_all’
    ```

Use bind_rows() instead of rbind_all()
up `dplyr` requirement to 0.5.0 for `bind_rows()`
@wch wch merged commit 57223f2 into rstudio:master Oct 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.