Skip to content

cols_hide() has a documentation issue and error msg #1631

@olivroy

Description

@olivroy

Description

library(gt)

exibble |> 
  gt() |> 
  cols_hide()
#> Error in translate_legacy_resolver_expr(quo, null_means): l'argument "expr" est manquant, avec aucune valeur par défaut

Created on 2024-04-24 with reprex v2.1.0

The message when you forget to supply input to cols_hide() is a bit ugly and the docs is misleading.

Docs are this currently

Columns to target<column-targeting expression>// default: everything()

Expected result

I think that the documentation should be updated and say that columns must be supplied.

I also think it would be better to use rlang::check_required() in cols_hide() to avoid an ugly message.

I don't think having the documented everything() as a default is a good idea. (documentation was not updated when #1342 was resolved)

I think the implentation of the function is (almost) okay.

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions