Enhance functions that generate summary rows#1159
Merged
rich-iannone merged 129 commits intomasterfrom Dec 10, 2022
Merged
Conversation
…into summary-rows-enhance
This was referenced Dec 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is concerned with various improvements to the
summary_rows()andgrand_summary_rows()functions. The changes should allow for more flexibility in providing the aggregation functions (optionally along withidandlabelvalues). There is also a need to have better ways to expressing the formatting of summary cell values.Fixes: #785
Fixes: #784
Fixes: #581
Fixes: #545
Fixes: #292
Fixes: #270