Fix conflict between tab_spanner_delim() and cols_label()#1173
Merged
rich-iannone merged 4 commits intomasterfrom Dec 17, 2022
Merged
Fix conflict between tab_spanner_delim() and cols_label()#1173rich-iannone merged 4 commits intomasterfrom
tab_spanner_delim() and cols_label()#1173rich-iannone merged 4 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tab_spanner_delim()function writes new column labels for split column names. However, usingcols_label()beforetab_spanner_delim()means that any set labels will be overwritten. This PR ensures that any column label that was changed will keep that change even after invokingtab_spanner_delim().Fixes: #1130