wrapping up word updates for V0.9.0 #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… length values in parse_to_xml
rich-iannone
requested changes
Mar 28, 2023
Member
rich-iannone
left a comment
rich-iannone
left a comment
There was a problem hiding this comment.
This is all great! Could you do one more small thing: wherever you call zip() and unzip(), prepend those with utils::. This is to remove notes from R CMD check.
Collaborator
Author
no problemo |
rich-iannone
approved these changes
Mar 28, 2023
Member
rich-iannone
left a comment
rich-iannone
left a comment
There was a problem hiding this comment.
This is great. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add iconv to gtsave output to ensure utf-8 output and handle multiple length values in parse_to_xml
Summary
Thank you for contributing to gt! To make this process easier for everyone, please explain the context and purpose of your contribution. Also, list the changes made to the existing code or documentation.
Review of open PRs, closes #1204, #1057
Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.