Skip to content

Conversation

@bastistician
Copy link
Contributor

On my Alpine Linux check system, I see

  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Error ('test-gt_object.R:188:3'): A gt table can use UTF-8 chars in any system locale ──
  <cmdError/error/condition>
  Error in `system("locale -a", intern = TRUE)`: error in running command
  Backtrace:
      ▆
   1. └─base::system("locale -a", intern = TRUE) at test-gt_object.R:188:2
  
  [ FAIL 1 | WARN 0 | SKIP 0 | PASS 799 ]
  Error: Test failures

This PR simply skips this test if locale -a fails to run (it is already skipped on Windows as well).
With this change, gt 0.9.0 checks fine on my system.

@netlify
Copy link

netlify bot commented Jun 18, 2023

Deploy Preview for quarto-gt-examples failed.

Name Link
🔨 Latest commit f366e5b
🔍 Latest deploy log https://app.netlify.com/sites/quarto-gt-examples/deploys/64b98f1a5402990008898197

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rich-iannone
Copy link
Member

And sorry this took so long to review. Will merge now though!

@rich-iannone rich-iannone merged commit 5f449cf into rstudio:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants