Possible performance improvement - call utils::packageVersion only once
#1525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
reviewed
Jan 5, 2024
Collaborator
olivroy
left a comment
olivroy
left a comment
There was a problem hiding this comment.
Maybe this could be simplified to just using markdown? since v1.5 is required in DESCRIPTION
Co-authored-by: olivroy <52606734+olivroy@users.noreply.github.com>
Co-authored-by: olivroy <52606734+olivroy@users.noreply.github.com>
Contributor
Author
|
I've tried signing https://cla-assistant.io/rstudio/gt?pullRequest=1525 but maybe I've messed up some emails somewhere... |
Contributor
Author
|
Fixed again :) Sorry - I'd missed the latex use of |
Member
|
@slodge Thank you! I was just debugging this and traced it to there (then I noticed your commits!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small performance improvement - no longer calls
utils::packageVersionRelated GitHub Issues and PRs
Fixes: #1524
Checklist
testthatunit tests totests/testthatfor any new functionality.