Run usethis::use_mit_license() to fix license page title#1598
Merged
rich-iannone merged 1 commit intorstudio:masterfrom Mar 1, 2024
nanxstats:master
Merged
Run usethis::use_mit_license() to fix license page title#1598rich-iannone merged 1 commit intorstudio:masterfrom nanxstats:master
usethis::use_mit_license() to fix license page title#1598rich-iannone merged 1 commit intorstudio:masterfrom
nanxstats:master
Conversation
Member
|
This is great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR runs
usethis::use_mit_license()to updateLICENSE.mdwith the latest template in usethis.As a result, this change fixes and improves two things:
The title is now an h1 element so that the full license page title won't become "NA" in pkgdown (screenshot below).
The body text now will not contain any non-ASCII characters (curly quotes) but will still be rendered properly in pkgdown because of the smart quotes interpretation in pandoc.
This is a purely cosmetic change and does not warrant a news item or unit test.
Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.