Improve tab_footnote() error message

[olivroy]

Summary

Basically uses withCallingHandlers() to give more precise location.

These are probably already tested by I used snapshots to display the user-facing messages. Tried to use tidyverse style guide + cli pluralization when possible.

The reprex in #475 now prints.

It mentions which footnote it was to be able to find it more easily + the offending function where column selection couldn't be resolved.

approach adding a bunch of call for error chaining.

For mentioning the function, you can see that I added manually the name of the function for better display (there were just a couple of instances.

TIL this in case it can be helpful!

f <- function(x) {
  g(x)
}

f2 <- function(x) {
  g(x, call = call("my_fn"))
}
f3 <- function(x) {
  f_user_face <- "my_fn"
  g(x, call = call(f_user_face))
  
}

g <- function(x, call = rlang::caller_env()) {
  
  cli::cli_abort("{x}", call = call)
}

f(23)
#> Error in `f()`:
#> ! 23

f2(23)
#> Error in `my_fn()`:
#> ! 23

f3(23)
#> Error in `my_fn()`:
#> ! 23

^{Created on 2024-04-25 with reprex v2.1.0}

Related GitHub Issues and PRs

Fixes #475

Checklist

• I understand and agree to the Code of Conduct.
• I have listed any major changes in the NEWS.
• I have added testthat unit tests to tests/testthat for any new functionality.

q: will the message work if the footnote is gr or md?

[rich-iannone]

Thank you for contributing this! Will review shortly, then merge.

[rich-iannone]

LGTM!