Merged
Conversation
3 tasks
rich-iannone
approved these changes
May 24, 2024
Member
rich-iannone
left a comment
There was a problem hiding this comment.
LGTM, thank you for this!
Member
|
Let me know if you plan any more changes for this (just want to be sure of it). |
Collaborator
Author
|
I was done with my changes here, unless changes are requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For review, I'd suggest to look at code here, but if you want to have a visual feel of how this translates in real-life, I added links to important commits in #1681 that may help pinpoint the essence of the PR.
To have an idea of how this PR improves things.
Look at 472510f in #1681 which displays how certain messages improved.
30938f0 also helps to see the visual impact of some of my previous changes.
See #1681
Related GitHub Issues and PRs
Fixes #1681.
Related to #1638 and #1640.
I may add snapshot tests eventually, but given the size of the PR, I don't want to commit too many changes that may slow down development. (It took me a while to get all checks passing because of the size of the PR)
Checklist
testthatunit tests totests/testthatfor any new functionality.