Skip to content

Add locale to info_time_style() and info_date_style() #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rich-iannone merged 1 commit into from
Jul 4, 2024
Merged

Add locale to info_time_style() and info_date_style() #1747

rich-iannone merged 1 commit into from
Jul 4, 2024

Conversation

@olivroy
Copy link
Collaborator

@olivroy olivroy commented Jul 4, 2024

To preview time and date styles

With locale = "fr", I got this

image

rich-iannone
rich-iannone approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit ea3031f into rstudio:master Jul 4, 2024
@olivroy olivroy deleted the locale-time branch July 4, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rich-iannone rich-iannone rich-iannone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olivroy @rich-iannone