Performance improvements + test refactoring + standardize error message from resolver

[olivroy]

Summary

• Speed improvement.
• Test reorg
• Error message consistency

I calculated a 30-50% speed increase for summary_rows() generation. (Lost my reprex during the day)

Important note, took me a while to debug, but if using vctrs::vec_slice() instead of dplyr::filter(), if NA are possible, we have to check for !is.na() first, just like base subsetting.

.by doesn't reorder rows, but didn't seem to cause any issue!

Major refactoring of some test files.

Basically using

expect_match_html(
  gt_tbl,
  c("pattern1")
)

as a shortcut to

expect_match(
  render_as_html(gt_tbl),
  c("pattern1")
)

I added a way to iterate on pattern to test for multiple patterns.

I also separated tests and reordered them with my newly created RStudio snippet.

snippet newtest
	})
	
	test_that("${1:name}", {
		${0}

Checklist

• I understand and agree to the Code of Conduct.
• I have listed any major changes in the NEWS.
• I have added testthat unit tests to tests/testthat for any new functionality.

[rich-iannone]

LGTM!

[rich-iannone]

Thank you, these are all great improvements!