Respect tab_stubhead() in opt_interactive()+ fix rendering for missing row names
#1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_ihtml_translations()`.
…names + add comments about future `sub_missing()` support in `opt_interactive()`
olivroy
changed the title
stubhead in opt_interactive()tab_stubhead() in opt_interactive()+ fix rendering for missing row names
olivroy
commented
Jul 8, 2024
olivroy
commented
Jul 8, 2024
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1702, #1705. Fixes some rough edges for new feature introduced in #1711 and #1725
Intent is respecting
tab_stubhead()inopt_interactive(), by addingnameto groupname colDef() or rownames where appropriate.I noticed that
sub_missing()(and probably allsub_*()is ignored inopt_interactive(), but that will require more work another time!For clarity, I also factored out the translations since the intermediate variables are not useful for the final output.
Before this PR,
With this PR, stubhead label shows and NAs are correctly marked as NA instead of
...6